Namespace uri_templates caching by base_href.

Review Request #4107 — Created May 6, 2013 and submitted

Information

Djblets
master

Reviewers

Namespace uri_templates caching by base_href.

The uri_templates cache inside of resources was operating in a way that it was
global to the resource within any given server thread. This meant that if the
resource is namespaced in the URL (say, with Review Board's local sites), it
would sometimes return bad data. This change makes it namespace the cache using
the base_href, so there are effectively separate caches for each local site.
Wrote a unit test for this in reviewboard/webapi/tests.py

See http://reviews.reviewboard.org/r/4109/
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        djblets/webapi/resources.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (c84081b).
Loading...