Summary

Fix replying to file attachment comments when the file attachment is removed.

Review Request #4106 — Created May 6, 2013 and submitted May 6, 2013, 12:32 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix replying to file attachment comments when the file attachment is removed.

Commenting on a file attachment, then removing the file attachment, then
replying to the comment was broken. This was due to looking up the
associated review_request only using the relationship for active file
attachments. We now check the inactive_review_request relationship too.
This is something that screenshot comments already do, but that fix
never made it to file attachments.

A unit test was added for this.

Testing Done

Unit tests pass.

I was able to reproduce the problem locally and can verify that it's fixed
after this change.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (137 > 79 characters)	reviewbot	May 6, 2013, 12:24 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	May 6, 2013, 12:24 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/tests.py
    reviewboard/webapi/resources.py
  Ignored Files:

reviewboard/webapi/tests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (137 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (b8efdaa)

reviewboard/webapi/tests.py (Diff revision 1)

reviewboard/webapi/tests.py (Diff revision 1)