Summary

"Ship It!" emails only contain user's first name

Review Request #4104 — Created May 5, 2013 and submitted May 7, 2013, 5:10 p.m.

Information

Owner

rajasaur

Repository

Review Board

Branch

Bugs

2965

Depends On

Reviewers

Groups

reviewboard

People

Description

Show Users' fullname in review emails

When displaying the name in review emails, show the users' fullname if they have a first name setup. Otherwise show their username. This change is made in both html and text emails.

Testing Done

Manual. Tested with email setting on and off.

Issues

Description	From	Last Updated
This should just be changed to the way it was in the text template, namely: - {{review.user\|user_displayname}}	david	May 5, 2013, 7:49 p.m.
This one was already doing the right thing. Please revert this.	david	May 5, 2013, 7:49 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/templates/notifications/review_email.txt
    reviewboard/templates/notifications/review_email.html

reviewboard/templates/notifications/review_email.html (Diff revision 1)

The issue has been resolved. Show all issues

This should just be changed to the way it was in the text template, namely:

- {{review.user|user_displayname}}

reviewboard/templates/notifications/review_email.txt (Diff revision 1)

The issue has been resolved. Show all issues

This one was already doing the right thing. Please revert this.

rajasaur May 5, 2013, 7:50 p.m.

Sorry I assumed that the check for first_name or username wasn't done in djblets_utils.py. Reverted this change.

Diff:

Revision 2 (+1 -1)

Show changes

reviewboard/templates/notifications/review_email.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/templates/notifications/review_email.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (e373dd4). Thanks!