"Ship It!" emails only contain user's first name

Review Request #4104 — Created May 5, 2013 and submitted

Information

Review Board

Reviewers

Show Users' fullname in review emails

When displaying the name in review emails, show the users' fullname if they have a first name setup. Otherwise show their username. This change is made in both html and text emails.
Manual. Tested with email setting on and off.
Description From Last Updated

This should just be changed to the way it was in the text template, namely: - {{review.user|user_displayname}}

daviddavid

This one was already doing the right thing. Please revert this.

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/notifications/review_email.txt
        reviewboard/templates/notifications/review_email.html
    
    
  2. 
      
david
  1. 
      
  2. Show all issues
    This should just be changed to the way it was in the text template, namely:
    
    - {{review.user|user_displayname}}
  3. Show all issues
    This one was already doing the right thing. Please revert this.
    1. Sorry I assumed that the check for first_name or username wasn't done in djblets_utils.py. Reverted this change.
  4. 
      
RA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/templates/notifications/review_email.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
RA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (e373dd4). Thanks!
Loading...