Add support for modifying close descriptions in ReviewRequestEditor.
Review Request #4103 — Created May 4, 2013 and submitted
Add support for modifying close descriptions in ReviewRequestEditor. The close description code has been removed from reviews.js and reworked for the new review request editor code. Now, each of the three types of change description inputs have their own fields registered. Since these all have the same IDs right now (we determine which to put into the page in the template), the elementID has been changed to a selector. Along with this, since they all work on the same field in the review request model, we're using an array of registered fields and not a map (which we made no use of anyway).
Tested setting each type of change description and making sure it saved. Tested that only the draft change description auto-opened on load. Made sure all the other fields still work. Added new unit tests, which all pass.
| Description | From | Last Updated |
|---|---|---|
|
You have duplicate IDs here. |
 david
|
-
-
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js (Diff revision 1) You have duplicate IDs here.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: Ignored Files: reviewboard/static/rb/js/reviews.js reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/reviewRequestEditorView.js