Summary

Move the action menus, DnD uploads and onbeforeunload to ReviewRequestEditorView.

Review Request #4102 — Created May 4, 2013 and submitted May 5, 2013, 3:14 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Move the action menus, DnD uploads and onbeforeunload to ReviewRequestEditorView.

The code from reviews.js for handling the menus, initializing the
DnDUploader and prompting on page change while there are pending edits
have been moved into ReviewRequestEditorView.

The action-related code has been consolidated into a _setupActions
function.

Testing Done

Tested the menu items in the menus, and that menus opened.

Tested that I could drag-and-drop files into the review request.

Tested that I was warned when trying to leave the page when I had a pending edit.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (bc18b1b)