[reviewboard] Rational Team Concert Support

Review Request #4087 — Created May 1, 2013 and discarded

Information

Review Board
release-1.7.7

Reviewers

Patch against release-1.7.7 because master was not work :)

Right now integration supports patch compatible with Jazz Patch 1.0
Unfortunately I were not able test it against RTC 4.0.2 server configured with BASIC authentication method.
Testing against BASIC authentication method and Websphere will be VERY helpful.
While testing patches generated in Eclipse environment was used however it also should works against patches generated by command-line tool.
DiffParser base on '#before_state" information to fetch information.
Username and password to RTC Repository are required!

IMPORTANT!!!
User given in repository configuration must be member of all necessery Project Areas and Team Areas, have assigned license and role to be able to read source control content!!!
Check credentials and Access Control configuration twice before you raise issue!!!

TODO:
* Handle "createemptyfile"
* Diff with new files
* Diff with changes
* Diff with deleted files
* Diff with moved files
* Against RTC Tomcat with FORM authentication method
Description From Last Updated

Col: 21 E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 36 E711 comparison to None should be 'if cond is not None

reviewbotreviewbot

Col: 32 E225 missing whitespace around operator

reviewbotreviewbot

Col: 75 E502 the backslash is redundant between brackets

reviewbotreviewbot

Col: 19 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 38 E203 whitespace before ','

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 80 E501 line too long (108 > 79 characters)

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 10 E111 indentation is not a multiple of four

reviewbotreviewbot

Col: 21 E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Col: 36 E711 comparison to None should be 'if cond is not None

reviewbotreviewbot

Col: 75 E502 the backslash is redundant between brackets

reviewbotreviewbot

Col: 19 E128 continuation line under-indented for visual indent

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/models.py
        reviewboard/scmtools/admin.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/forms.py
        reviewboard/scmtools/rtc.py
        setup.py
      Ignored Files:
        reviewboard/templates/admin/repository_fields.js
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 31.
  2. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 21
     E126 continuation line over-indented for hanging indent
    
  3. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (81 > 79 characters)
    
  5. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  6. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 36
     E711 comparison to None should be 'if cond is not None
  7. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 32
     E225 missing whitespace around operator
    
  8. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 75
     E502 the backslash is redundant between brackets
    
  9. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 19
     E128 continuation line under-indented for visual indent
    
  10. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 38
     E203 whitespace before ','
    
  11. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  12. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  13. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (108 > 79 characters)
    
  14. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  15. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  16. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  17. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  18. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  19. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  20. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  21. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  22. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  23. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  24. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  25. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  26. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  27. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  28. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  29. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  30. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  31. reviewboard/scmtools/rtc.py (Diff revision 1)
     
     
    Show all issues
    Col: 10
     E111 indentation is not a multiple of four
    
  32. 
      
jan.koprowski
jan.koprowski
jan.koprowski
jan.koprowski
jan.koprowski
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/models.py
        reviewboard/scmtools/admin.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/forms.py
        reviewboard/scmtools/rtc.py
        setup.py
      Ignored Files:
        reviewboard/templates/admin/repository_fields.js
        .gitignore
    
    
  2. reviewboard/scmtools/rtc.py (Diff revision 2)
     
     
    Show all issues
    Col: 21
     E126 continuation line over-indented for hanging indent
    
  3. reviewboard/scmtools/rtc.py (Diff revision 2)
     
     
    Show all issues
    Col: 36
     E711 comparison to None should be 'if cond is not None
  4. reviewboard/scmtools/rtc.py (Diff revision 2)
     
     
    Show all issues
    Col: 75
     E502 the backslash is redundant between brackets
    
  5. reviewboard/scmtools/rtc.py (Diff revision 2)
     
     
    Show all issues
    Col: 19
     E128 continuation line under-indented for visual indent
    
  6. 
      
jan.koprowski
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/models.py
        reviewboard/scmtools/admin.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/forms.py
        reviewboard/scmtools/rtc.py
        setup.py
      Ignored Files:
        reviewboard/templates/admin/repository_fields.js
        .gitignore
    
    
  2. 
      
jan.koprowski
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/models.py
        reviewboard/scmtools/admin.py
        reviewboard/scmtools/core.py
        reviewboard/scmtools/forms.py
        reviewboard/scmtools/rtc.py
        setup.py
      Ignored Files:
        reviewboard/templates/admin/repository_fields.js
        .gitignore
    
    
  2. 
      
jan.koprowski
jan.koprowski
Review request changed
Status:
Discarded