Move some action handlers to ReviewRequestEditorView.

Review Request #4084 — Created April 28, 2013 and submitted

Information

Review Board
master

Reviewers

Move some action handlers to ReviewRequestEditorView.

ReviewRequestEditorView is now responsible for several of the actions
having to do with the draft. Right now, this consists of the various
forms of closing, reopening, and publishing. Down the road, the others
will move here.

Some of this is still less than nice because of our silly redundant IDs
for actions. That will be cleaned up later as that code gets turned into
nice new classes.
Tested each option in the Close menu.

Tested all buttons on the various draft banners (Publish, Reopen, both versions of Discard).

Tested that inlineEditors were all disabled when the review request was discarded (necessary
due to changing the whole editable logic from gEditable to a property on ReviewRequestEditor).

Made sure I could edit fields and that validation passed, just in case.

Unit tests pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1)
     
     
     
     
     
     
    Ternary operator?
  3. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
        reviewboard/templates/reviews/review_detail.html
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...