Summary

Add the djblets.feedview app for viewing RSS/Atom feeds

Review Request #408 — Created June 7, 2008 and submitted

Information

Owner

chipx86

Repository

Navi (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This introduces the new djblets.feedview app, which is designed to allow sites to embed RSS/Atom feeds. We make use of the single-file MIT-licensed "feedparser" module for this, which we ship along with feedview.

This is to be used in the new admin UI for displaying Review Board news updates on the new dashboard.

Testing Done

Tested along with the new admin UI. Viewing feeds works fine.

/trunk/djblets/djblets/feedview/feedparser.py (Diff revision 1)

Huh.  This doesn't look right.

chipx86 June 9, 2008, 9:09 a.m.

Yeah, but it shouldn't hurt us... I'd rather not modify feedparser code. It's easier if we can just drop in new versions down the road.

david June 9, 2008, 9:15 a.m.

It looks like this is meant to be used via "svn cat" (or equivalent), so it fills in the revision number.  I'd really like to have that number here so we know which version of feedparser we've got.

chipx86 June 9, 2008, 10:54 a.m.
```
Fixing this. It'll be in my commit.
```

/trunk/djblets/djblets/feedview/views.py (Diff revision 1)

Do you need to escape url here?

chipx86 June 9, 2008, 10:53 a.m.

Could have sworn I replied to this, but I guess not. I think that was while my wireless drivers messed up and had to be reset...

Anyhow, it worked during my tests. I thought about escaping it but I don't know that we're using any invalid characters in general. If anything, maybe cache_memoize should escape keys that come in.