Add the beginnings of the ReviewRequestEditor and view.

Review Request #4055 — Created April 17, 2013 and submitted

Information

Review Board
master

Reviewers

Add the beginnings of the ReviewRequestEditor and view.

Right now, this just tracks thumbnails and general editing/publishing
state. Most of the real logic still exists in reviews.js.

In time, this will handle all aspects of review request editing.

Unit tests were added for all the current event hookups, rendering,
thumbnail importing, and more.
Tested pages with existing screenshots and file attachments. Made
sure I could edit the captions and delete the screenshots.

Tested uploading new file attachments (through drag-and-drop and through
Add File). Tested that I could edit and delete those.

Tested that edit state seemed to still work on fields.

Tested the draft banner when saving fields and uploading.

Unit tests passed.
Description From Last Updated

I don't think this comment really adds anything that the function name didn't already tell me.

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
        reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/dndUploaderView.js
        reviewboard/static/rb/js/models/tests/reviewRequestModelTests.js
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/rb/js/models/reviewRequestModel.js
        reviewboard/static/rb/js/models/reviewRequestEditorModel.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/commentEditorModel.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    
    
  2. 
      
david
  1. 
      
  2. I don't think this comment really adds anything that the function name didn't already tell me.
    1. I changed the name of the function after adding the comment. It was less clear before. Removing the comment.
  3. I don't think I understand when ReviewRequest.createFileAttachment should be used...
    1. It probably shouldn't be used by anything but the editor right now. Maybe I'll nuke the ReviewRequest one later, but not in this change.
      
      My feeling is that I'd like to keep the "parentObject" bit internal to whatever object would be set as the parentObject.
  4. 
      
chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
        reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
        reviewboard/static/rb/js/models/commentEditorModel.js
        reviewboard/static/rb/js/models/reviewRequestEditorModel.js
        reviewboard/static/rb/js/views/dndUploaderView.js
        reviewboard/static/rb/js/reviews.js
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/static/rb/js/models/tests/reviewRequestModelTests.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/js/models/reviewRequestModel.js
        reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (a26ace8)
Loading...