Add the beginnings of the ReviewRequestEditor and view.
Review Request #4055 — Created April 17, 2013 and submitted
Add the beginnings of the ReviewRequestEditor and view. Right now, this just tracks thumbnails and general editing/publishing state. Most of the real logic still exists in reviews.js. In time, this will handle all aspects of review request editing. Unit tests were added for all the current event hookups, rendering, thumbnail importing, and more.
Tested pages with existing screenshots and file attachments. Made sure I could edit the captions and delete the screenshots. Tested uploading new file attachments (through drag-and-drop and through Add File). Tested that I could edit and delete those. Tested that edit state seemed to still work on fields. Tested the draft banner when saving fields and uploading. Unit tests passed.
| Description | From | Last Updated |
|---|---|---|
|
I don't think this comment really adds anything that the function name didn't already tell me. |
 david
|
- Change Summary:
-
Removed a comment.
- Diff:
-
Revision 2 (+803 -200)
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js reviewboard/static/rb/js/models/commentEditorModel.js reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/dndUploaderView.js reviewboard/static/rb/js/reviews.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/models/tests/reviewRequestModelTests.js reviewboard/templates/reviews/reviewable_base.html reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/models/reviewRequestModel.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/views/reviewRequestEditorView.js reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js reviewboard/templates/reviews/reviewable_base.html reviewboard/static/rb/js/views/dndUploaderView.js reviewboard/static/rb/js/models/tests/reviewRequestModelTests.js reviewboard/templates/reviews/review_request_box.html reviewboard/static/rb/js/reviews.js reviewboard/static/rb/js/models/reviewRequestModel.js reviewboard/static/rb/js/models/reviewRequestEditorModel.js reviewboard/static/rb/js/views/commentDialogView.js reviewboard/static/rb/js/models/commentEditorModel.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js