Fix the PYTHONPATH issue for good (hopefully).

Review Request #4049 — Created April 14, 2013 and submitted

Information

Review Board
master

Reviewers

Fix the PYTHONPATH issue for good (hopefully).

The latest change to set PYTHONPATH to be limited to the location of the
settings_local.py file broke virtualenvs, which no longer set PYTHONPATH
correctly and break rbssh.

PYTHONPATH seems to be a complicated beast when virtualenvs and
pkg_resources comes in, so we're just going to stop dealing with it
here. Instead, we're using a new variable, RBSITE_PYTHONPATH, which will
point to any paths we have within a site that we care about. For now,
this is the conf/ directory. rbssh will specifically look for this and
add the values to sys.path.
Unit tests now pass again.

Verified that the conf dir ended up in sys.path.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/cmdline/rbssh.py
        reviewboard/__init__.py
      Ignored Files:
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (d36f0e1)
Loading...