Fix errors with the use_ticket_auth form field.

Review Request #4035 — Created April 9, 2013 and submitted

Information

Review Board
release-1.7.x

Reviewers

Fix errors with the use_ticket_auth form field.

When saving repositories, we can sometimes hit an issue where get_scmtool()
fails due to the repository object not actually existing. Since we don't really
care about having this in extra_data for repositories which don't support ticket
auth, we don't need to include this check.
Ran unit tests.
Description From Last Updated

What concerns me is that this doesn't break in any unit tests. Maybe we should add one. Also, does this …

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/scmtools/forms.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/scmtools/forms.py (Diff revision 1)
     
     
     
     
     
     
    Show all issues
    What concerns me is that this doesn't break in any unit tests. Maybe we should add one.
    
    Also, does this still work for Perforce? Isn't it a core problem?
    1. The problem was in the get_scmtool() call, not in the extra_data update. It didn't hit in unit tests because it doesn't affect sqlite.
  3. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (a0b0340).