Summary

Fix errors with the use_ticket_auth form field.

Review Request #4035 — Created April 10, 2013 and submitted April 10, 2013, 12:59 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix errors with the use_ticket_auth form field.

When saving repositories, we can sometimes hit an issue where get_scmtool()
fails due to the repository object not actually existing. Since we don't really
care about having this in extra_data for repositories which don't support ticket
auth, we don't need to include this check.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
What concerns me is that this doesn't break in any unit tests. Maybe we should add one. Also, does this …	chipx86	April 10, 2013, 12:52 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/scmtools/forms.py
  Ignored Files:

reviewboard/scmtools/forms.py (Diff revision 1)

The issue has been dropped. Show all issues

What concerns me is that this doesn't break in any unit tests. Maybe we should add one.

Also, does this still work for Perforce? Isn't it a core problem?

david April 10, 2013, 12:51 a.m.

The problem was in the get_scmtool() call, not in the extra_data update. It didn't hit in unit tests because it doesn't affect sqlite.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.7.x (a0b0340).