Fixed overzealous initialization of PYTHONPATH.

Review Request #4027 — Created April 7, 2013 and submitted

Information

Review Board
master

Reviewers

This is a bugfix over __init__.py that was inititalliy changed at https://github.com/reviewboard/reviewboard/commit/915452d483a812ee34006741a6f5c23a4d03a5b1

The current initialization is overzealous and conflicts with the installation call from extensionbrowser's easy_install usage (with the current initialization, an easy_install call would nuke all entries in the easy_install.pth file and overwrite previous entries).

 
Description From Last Updated

As briefly discussed in IRC, you were right before in that settings_local.__file__ is correct. Also, make sure both parameters align.

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/__init__.py
      Ignored Files:
    
    
  2. 
      
AY
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/__init__.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/__init__.py (Diff revision 2)
     
     
    For future reference, settings must always be imported as:
    
        from django.conf import settings
    
    Of course, in this case, we'll actually want settings_local, as you had before. See below:
  3. reviewboard/__init__.py (Diff revision 2)
     
     
    As briefly discussed in IRC, you were right before in that settings_local.__file__ is correct.
    
    Also, make sure both parameters align.
  4. 
      
AY
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/__init__.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
AY
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (996026c)
Loading...