Summary

Fix should_update_issue_status to avoid uncaught exceptions.

Review Request #4025 — Created April 5, 2013 and submitted April 8, 2013, 1:13 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix should_update_issue_status to avoid uncaught exceptions.

Every so often, I see a traceback from our servers coming from
BaseCommentResource.should_update_issue_status. The issue here is that
issue_status isn't in the kwargs, but our issue_string_to_status will raise an
exception if the passed-in value is None. This changes it to always return False
in the case that issue_status isn't in kwargs, and fixes up a little bit of
formatting.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Can we just put this in the parameter list for the function? And issue_opened?	chipx86	April 5, 2013, 11:52 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	April 5, 2013, 11:49 p.m.
Col: 80 E501 line too long (89 > 79 characters)	reviewbot	April 6, 2013, 1:21 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources.py
  Ignored Files:

reviewboard/webapi/resources.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (89 > 79 characters)
```

reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we just put this in the parameter list for the function? And issue_opened?
```

Diff:

Revision 2 (+9 -7)

Show changes

reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources.py
  Ignored Files:

reviewboard/webapi/resources.py (Diff revision 2)

The issue has been resolved. Show all issues

Col: 80
 E501 line too long (89 > 79 characters)

chipx86 April 6, 2013, 2:01 a.m.

It'd be nice to fix this. Maybe just compute issue_string_to_status before the statement.

Diff:

Revision 3 (+11 -7)

Show changes

reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/webapi/resources.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (efeb640).