Fix should_update_issue_status to avoid uncaught exceptions.

Review Request #4025 — Created April 5, 2013 and submitted

Information

Review Board
release-1.6.x

Reviewers

Fix should_update_issue_status to avoid uncaught exceptions.

Every so often, I see a traceback from our servers coming from
BaseCommentResource.should_update_issue_status. The issue here is that
issue_status isn't in the kwargs, but our issue_string_to_status will raise an
exception if the passed-in value is None. This changes it to always return False
in the case that issue_status isn't in kwargs, and fixes up a little bit of
formatting.
Ran unit tests.
Description From Last Updated

Can we just put this in the parameter list for the function? And issue_opened?

chipx86chipx86

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (89 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/resources.py
      Ignored Files:
    
    
  2. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
  3. 
      
chipx86
  1. 
      
  2. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    Can we just put this in the parameter list for the function? And issue_opened?
  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/resources.py
      Ignored Files:
    
    
  2. reviewboard/webapi/resources.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (89 > 79 characters)
    
    1. It'd be nice to fix this. Maybe just compute issue_string_to_status before the statement.
  3. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/webapi/resources.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (efeb640).
Loading...