This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/patch.py Ignored Files:
Fix references to non-existant variables in rbt patch.
Review Request #4022 — Created April 5, 2013 and submitted
rbt patch in RBTools 0.5 is pretty broken - it was using attributes which didn't exist (Patch.repository_info and Patch.tool instead of the local variables that it creates). I was getting the following error messages before these fixes (not all at once) CRITICAL:root:'Patch' object has no attribute 'repository_info' CRITICAL:root:'Patch' object has no attribute 'tool' CRITICAL:root:'NoneType' object has no attribute 'get_diffs'
ran rbt patch successfully flake8 patch.py