This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/api/transport/sync.py rbtools/api/client.py rbtools/commands/__init__.py rbtools/api/transport/__init__.py Ignored Files:
smacleod got a fish trophy!
Add a method for retreiving resources from a path
Review Request #4004 — Created March 26, 2013 and submitted
Add a method for retreiving resources from a path The RBClient now has a 'get_path' method which will accept a path and retreive the API resource at that path. For example a path of '/review-requests/123' would retreive the resource at 'http://example.com/api/review-requests/123' A 'ParseError' Exception has also been added for commands. If there is an error parsing the command arguments or options, the command should raise a ParseError.
Used the new 'get_path' method as part of a new command providing some lower level access to API resources. This command also utilizes the ParseError. Verified get_path was generating correct HttpRequests, and returning the expected resource. Verfified the old behaviour when raising a CommandError, and tested ParseError by raising in a commands main. The ParseError caused the expected usage output and error message.
Loading file attachments...
Where is this raised?
Updated the testing done.