smacleod got a fish trophy!

Summary

Add a method for retreiving resources from a path

Review Request #4004 — Created March 26, 2013 and submitted April 8, 2013, 3:29 p.m.

Information

Owner

smacleod

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Add a method for retreiving resources from a path

The RBClient now has a 'get_path' method which will accept a path and
retreive the API resource at that path. For example a path of
'/review-requests/123' would retreive the resource at
'http://example.com/api/review-requests/123'

A 'ParseError' Exception has also been added for commands. If there is
an error parsing the command arguments or options, the command should
raise a ParseError.

Testing Done

Used the new 'get_path' method as part of a new command providing some
lower level access to API resources. This command also utilizes the
ParseError.

Verified get_path was generating correct HttpRequests, and returning
the expected resource. Verfified the old behaviour when raising
a CommandError, and tested ParseError by raising in a commands main.
The ParseError caused the expected usage output and error message.

Issues

Description	From	Last Updated
Where is this raised?	david	April 4, 2013, 9:03 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/api/transport/sync.py
    rbtools/api/client.py
    rbtools/commands/__init__.py
    rbtools/api/transport/__init__.py
  Ignored Files:

```
Testing done?
```

rbtools/commands/__init__.py (Diff revision 1)

The issue has been dropped. Show all issues

Where is this raised?

smacleod April 4, 2013, 9:03 p.m.

This is raised by a new command which will be part of a separate
change. The new command will rely on the code from this patch, as
well as API refactoring coming in another request.

Change Summary:: Updated the testing done.
Testing Done:: +
Used the new 'get_path' method as part of a new command providing some
+ lower level access to API resources. This command also utilizes the
+ ParseError.
+
+
Verified get_path was generating correct HttpRequests, and returning
+ the expected resource. Verfified the old behaviour when raising
+ a CommandError, and tested ParseError by raising in a commands main.
+ The ParseError caused the expected usage output and error message.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (8a35af2fcb8f6f0c485899572bdbd91f7994b766).

	+	Used the new 'get_path' method as part of a new command providing some
	+	lower level access to API resources. This command also utilizes the
	+	ParseError.
	+
	+	Verified get_path was generating correct HttpRequests, and returning
	+	the expected resource. Verfified the old behaviour when raising
	+	a CommandError, and tested ParseError by raising in a commands main.
	+	The ParseError caused the expected usage output and error message.