Stop passing unicode keys to **kwargs

Review Request #4003 — Created March 26, 2013 and discarded

Information

RBTools
master

Reviewers

Stop passing unicode keys to **kwargs

Python < 2.6.5 will raise an exception if a any unicode keys are
passed to **kwargs. When generating link objects from fields inside a
resource (e.g. The target_people field on a review request) the
dictionary decoded from the JSON payload was passed as **kwargs to
initialize the object. Since the JSON decodes to unicode, older python
versions were crashing here.

 
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/api/transport/sync.py
      Ignored Files:
    
    
  2. 
      
david
  1. Testing done?
    1. The refactoring I've done to the API since this change (Which will
      go up shortly) actually handles this in a different way. I'm going
      to discard this review request.
  2. 
      
SM
Review request changed

Status: Discarded

Loading...