None

chipx86 got review request #4000!

Fix a couple issues with resource loading/saving.

Review Request #4000 — Created March 24, 2013 and submitted

Information

Review Board
master

Reviewers

Fix a couple issues with resource loading/saving.

BaseResource's URL, when containing an ID, left off the trailing slash.
While it still worked fine, it did result in a redirect, and thus an
extra call to the server for every URL.

Doing a GET had other small but harmless issues. It provided a
contentType and attribute data, even though these weren't wanted in a
GET.
Verified it works in the change where I first noticed this.

New unit tests pass. Verified they didn't before.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/rb/js/models/baseResourceModel.js
        reviewboard/static/rb/js/models/tests/baseResourceModelTests.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...