Refactor the screenshotThumbnail code to be largely a Backbone view.

Review Request #3997 — Created March 23, 2013 and submitted

Information

Review Board
master

Reviewers

Refactor the screenshotThumbnail code to be largely a Backbone view.

The bulk of $.fn.screenshotThumbail has been pulled out into a Backbone
view. The view handles hooking up events to the model and elements, and
performing modification and deletion actions on the screenshot.

$.fn.screenshotThumbnail itself still exists to query the proper
screenshot to populate the view with, and to hook up events to the
editing state for the review request. In time, this will all move into a
new view that owns review request editing.
Edited and deleted screenshots successfully.

Observed the button and draft banner states to make sure they reacted properly.

Unit tests passed.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/rb/js/models/baseResourceModel.js
        reviewboard/static/rb/js/views/tests/screenshotThumbnailViewTests.js
        reviewboard/static/rb/js/views/screenshotThumbnailView.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...