• 
      

    Fix up some problems with the ReviewReply model

    Review Request #3991 — Created March 22, 2013 and submitted

    Information

    Review Board
    master

    Reviewers

    Fix up some problems with the ReviewReply model
    
    There were a couple issues with RB.ReviewReply from my previous implementation.
    First, I had used underscores in the property names instead of using camelCase.
    This involved some changes to the plumbing but is less than I had expected.
    Second, the _.defaults call wasn't passing in the correct prototype defaults, so
    the resulting object didn't have some of the right attributes.
    Replied to a review with diff comments, body_top and body_bottom fields.
    reviewbot
    1. This is a review from Review Bot.
        Tool: PEP8 Style Checker
        Processed Files:
        Ignored Files:
          reviewboard/static/rb/js/reviews.js
          reviewboard/static/rb/js/models/tests/reviewReplyModelTests.js
          reviewboard/static/rb/js/models/reviewReplyModel.js
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (e045c62).