Add support for registered GitHub OAuth applications.

Review Request #3967 — Created March 14, 2013 and submitted — Latest diff uploaded

Information

Review Board
release-1.7.x

Reviewers

Add support for registered GitHub OAuth applications.

Registered GitHub OAuth applications have the added benefits of central
revocation of a key and higher rate limits. While it's not possible for
us to turn this on for every installation out there (since sharing a
client secret is a very bad idea), those who need it can register their
own application entry and set it up with Review Board.

This is a pretty advanced feature, so there's no UI-side configuration
for this. Those who need it are expected to set the
settings.GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET keys.
Unit tests pass.

Tested with a registered OAuth application and verified that the resulting
payload referenced the URL the application provided, and that GitHub was
aware of my authorization in that application's user count.
    Loading...