Additional Branch and Revision optional fields within Submission Banner

Review Request #3965 — Created March 13, 2013 and discarded — Latest diff uploaded

Information

Review Board
master

Reviewers

Feature
- This feature adds two additional optional fields to the Submit banner alongside the original "describe your submission"; being "Revision" and Branch". 
- These new fields are dynamically addressed in the change log found at the bottom of a review request.

NOTE: This review request is currently bugged, as it is not allowing the removal of the following issues from the tracker:
File 17, 18, 33, 34, 38. Consider these issues dealt with.
THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING DISCARDED
- Typing nothing proceeds with empty bottom log other then signal for status change, as expected.

- Take a newly published request, cursor over the Close drop down, click discarded. The discard banner appears, as expected. Typing in a reason for discard proceeds as normal.

THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING SUBMITTED
- Typing nothing proceeds with empty bottom log other then signal for status change, as expected.

- Typing only in the description area, the text area expands, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed description under its proper heading.

- Typing only in the revision/branch area, the text label switches to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch under its proper heading.

- Typing in all three areas, the text labels switch to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch/description under their proper headings.

- Typing in any of the labels as described previously, but then changing your mind and overwriting to another input. The bottomt change log adjusts to the newest version of text.

    Loading...