Summary

Additional Branch and Revision optional fields within Submission Banner

Review Request #3965 — Created March 13, 2013 and discarded Jan. 9, 2015, 3:58 p.m.

Information

Owner

Demelo

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Feature
- This feature adds two additional optional fields to the Submit banner alongside the original "describe your submission"; being "Revision" and Branch". 
- These new fields are dynamically addressed in the change log found at the bottom of a review request.

NOTE: This review request is currently bugged, as it is not allowing the removal of the following issues from the tracker:
File 17, 18, 33, 34, 38. Consider these issues dealt with.

Testing Done

THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING DISCARDED
- Typing nothing proceeds with empty bottom log other then signal for status change, as expected.

- Take a newly published request, cursor over the Close drop down, click discarded. The discard banner appears, as expected. Typing in a reason for discard proceeds as normal.

THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING SUBMITTED
- Typing nothing proceeds with empty bottom log other then signal for status change, as expected.

- Typing only in the description area, the text area expands, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed description under its proper heading.

- Typing only in the revision/branch area, the text label switches to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch under its proper heading.

- Typing in all three areas, the text labels switch to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch/description under their proper headings.

- Typing in any of the labels as described previously, but then changing your mind and overwriting to another input. The bottomt change log adjusts to the newest version of text.

Files

Issues

Description	From	Last Updated
I'm not sure this is the best format to use. The description is by no means restricted to a single …	SM smacleod	March 13, 2013, 6:41 p.m.
I think we should probably use single line input boxes for these (similar to the branch field describing the review …	SM smacleod	March 13, 2013, 6:41 p.m.
It's hard to tell which screenshots are of the current project. If you can remove any that don't represent the …	chipx86	March 31, 2013, 2:24 p.m.
The "(optional)" is too wordy and inconsistent from the rest of the UI. Every field is optional unless it has …	chipx86	March 31, 2013, 2:25 p.m.
I meant the labels themselves, not the values. Like on a review request, how "Branch" and "Submitter" and stuff are …	chipx86	April 2, 2013, 2:33 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	March 13, 2013, 1:27 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	March 13, 2013, 1:27 a.m.
Col: 48 W291 trailing whitespace	reviewbot	March 13, 2013, 1:28 a.m.
Col: 24 E711 comparison to None should be 'if cond is not None	reviewbot	March 13, 2013, 1:28 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 13, 2013, 1:28 a.m.
Col: 21 E711 comparison to None should be 'if cond is not None	reviewbot	March 13, 2013, 1:29 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 13, 2013, 1:29 a.m.
Col: 19 E711 comparison to None should be 'if cond is not None	reviewbot	March 13, 2013, 1:29 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 13, 2013, 1:29 a.m.
Col: 53 E711 comparison to None should be 'if cond is not None	reviewbot	March 13, 2013, 1:29 a.m.
Col: 58 W291 trailing whitespace	reviewbot	March 13, 2013, 1:30 a.m.
Col: 50 E711 comparison to None should be 'if cond is not None	reviewbot	March 13, 2013, 1:30 a.m.
Col: 56 W291 trailing whitespace	reviewbot	March 13, 2013, 1:30 a.m.
Col: 48 E711 comparison to None should be 'if cond is not None	reviewbot	March 13, 2013, 1:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 13, 2013, 1:31 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 13, 2013, 1:31 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	March 13, 2013, 1:32 a.m.
Col: 68 W291 trailing whitespace	reviewbot	March 13, 2013, 1:35 a.m.
This max_length is probably too short.	SM smacleod	March 20, 2013, 1:15 p.m.
This max length is definitely too short, sha1s are twice this length.	SM smacleod	March 20, 2013, 1:15 p.m.
Again, probably too short	SM smacleod	March 20, 2013, 1:15 p.m.
I'm thinking we probably don't want to do it this way. It would be nicer to have each of these …	SM smacleod	March 31, 2013, 7:02 p.m.
Trailing whitespace (Review Bot only checks .py files, so you'll have to manually inspect the js, or enable stripping of …	SM smacleod	March 20, 2013, 1:18 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 31, 2013, 5:02 a.m.
Col: 56 W291 trailing whitespace	reviewbot	April 3, 2013, 12:05 p.m.
Col: 69 W291 trailing whitespace	reviewbot	April 3, 2013, 12:05 p.m.
Col: 61 E272 multiple spaces before keyword	reviewbot	April 3, 2013, 12:05 p.m.
Please alphabetically order these properties, and get rid of the commented out property.	mike_conley	April 5, 2013, 9:40 a.m.
Needs 2 space indentation here, and a space between : and inline-block.	mike_conley	April 5, 2013, 9:41 a.m.
Too much indent here.	mike_conley	April 5, 2013, 9:41 a.m.
Each of these variables need "var" in front of them. Plus, we might as well use "revision", "branch". "desc" is …	mike_conley	April 5, 2013, 9:47 a.m.
var in front of these	mike_conley	April 5, 2013, 9:47 a.m.
Needs var in front of these, and use "revision" and "branch".	mike_conley	April 5, 2013, 9:47 a.m.
I don't know that we need new fields for this. Any additional fields are supposed to lie in fields_changed.	chipx86	April 6, 2013, 11:12 a.m.
Not sure we need this. We already will be storing the information in the change description, and will be parsing …	chipx86	April 6, 2013, 11:13 a.m.
So this is completely changing how we handle these fields, and will break every existing review request out there. The …	chipx86	April 6, 2013, 11:13 a.m.
This is the perfect case of where you want to target a class instead of IDs.	chipx86	April 6, 2013, 11:13 a.m.
Can you just do: if (options.revision) Or will that not work?	chipx86	April 6, 2013, 12:20 p.m.
Why is this different from revision?	chipx86	April 6, 2013, 12:20 p.m.
Remove the magic number 1, and just use Rb.ReviewRequest.CLOSE_DISCARDED.	mike_conley	April 6, 2013, 11:11 a.m.
I've just realized how fragile this is. Is jQuery.closest() not workable here? Same with the other parent().parent().parent() bit.	mike_conley	April 6, 2013, 12:04 p.m.
These are really hairy and scary. You should be able to make use of the ID for the banner.	chipx86	April 6, 2013, 12:04 p.m.
Same as above.	chipx86	April 6, 2013, 12:04 p.m.
Too much redundancy with the above. I think really, this entire function should be part of the above function. Any …	chipx86	April 6, 2013, 12:04 p.m.
We shouldn't do this query more than once. How about: $('#submitted-banner .editable') .reviewCloseCommentEditor(RB.ReviewRequest.CLOSE_SUBMITTED);	chipx86	April 6, 2013, 11:13 a.m.
Can we rename these IDs to "revision-description" and stuff? Using the "-". I know "changedescription" is there, but for new …	chipx86	April 6, 2013, 11:14 a.m.
Just submitted. We don't want revision or branch for the discard banner, just submitted.	chipx86	April 6, 2013, 11:14 a.m.
Should enforce that this only works for submitting.	chipx86	April 6, 2013, 12:20 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 12:55 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 6, 2013, 12:55 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 6, 2013, 12:55 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 12:55 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	April 6, 2013, 12:57 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 6, 2013, 12:58 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 12:58 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 6, 2013, 12:58 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	April 6, 2013, 12:58 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 6, 2013, 12:58 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	April 6, 2013, 12:58 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 1:01 p.m.
Col: 73 W291 trailing whitespace	reviewbot	April 6, 2013, 1:02 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 6, 2013, 1:01 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 6, 2013, 1:01 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	April 6, 2013, 1:01 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 6, 2013, 1:01 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	April 6, 2013, 1:01 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 6, 2013, 1:04 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 6, 2013, 1:04 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	April 6, 2013, 1:04 p.m.
Col: 80 E501 line too long (107 > 79 characters)	reviewbot	April 6, 2013, 1:04 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	April 6, 2013, 1:04 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	April 6, 2013, 1:04 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 48
 W291 trailing whitespace
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 24
 E711 comparison to None should be 'if cond is not None
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 21
 E711 comparison to None should be 'if cond is not None
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 19
 E711 comparison to None should be 'if cond is not None
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 53
 E711 comparison to None should be 'if cond is not None
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 58
 W291 trailing whitespace
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 50
 E711 comparison to None should be 'if cond is not None
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 56
 W291 trailing whitespace
```
reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 48
 E711 comparison to None should be 'if cond is not None
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```

Summary:: *[WIP]* Additional Branch and Revision field optionals within Submission Banner
*[WIP]* Additional Branch and Revision optional fields within Submission Banner

Change Summary:

Addressed PEP8

Diff:

Revision 2 (+74 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

reviewboard/webapi/resources.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 68
 W291 trailing whitespace
```

Change Summary:

Trailing whitespace ftl.

Diff:

Revision 3 (+74 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

Fix it!

Full changelog

An issue was opened. Show all issues

I'm not sure this is the best format to use. The description is by no means restricted to a single line, and this could look really strange with a multi-liner.

Also, it'd probably be easier to pick out the branch and revision if they were separate fields.

chipx86 March 23, 2013, 7:18 p.m.

I think I'd be happiest with:

"Submitted in revision 10 on branch 'reviews'"

Try making the "Submitted in revision" and "branch" look like the label style used for other fields, so it stands out from the description text.

Demelo March 31, 2013, 4:56 a.m.

I've addressed the first suggestion in my latest changes that will be resubmitted shortly, and I am now attempt to address the second suggestion.

More changes...

I think we should probably use single line input boxes for these (similar to the branch field describing the review request). I think it would look nicer, more compact, and it's all the functionality we need.

An issue was opened. Show all issues

I think we should probably use single line input boxes for these (similar to the branch field describing the review request). I think it would look nicer, more compact, and it's all the functionality we need.

chipx86 March 23, 2013, 7:18 p.m.

Agreed. This was the main thing that struck me when looking at the change.

DE

Demelo March 31, 2013, 5:04 a.m.
```
This is now my current target. 
```

reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This max_length is probably too short.
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This max length is definitely too short, sha1s are twice this length.
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Again, probably too short
```

reviewboard/reviews/models.py (Diff revision 3)

The issue has been resolved. Show all issues

I'm thinking we probably don't want to do it this way. It would be nicer to have each of these fields actually stored separately and displayed, instead of generating a message and sticking it in the text where description used to go.

Demelo March 31, 2013, 5:01 a.m.

So I have the model storing each of the inputs, but for now I've address one of the earlier comments suggesting a readability improvement in the current style of output. Check out the new screenshots to see if it's more to your liking. 

In terms of moving forward, the saved model fields definately could be used to produce a more developed means of output, but should that be left for a future project, either by myself or another student, keeping in mind the up coming deadlines? Just a thought.

Demelo March 31, 2013, 7:03 p.m.

Set as fixed as the first part was addressed, and the second has been reviewed in a more recent comment. Just trying to avoid duplicate review issues.

reviewboard/static/rb/js/reviews.js (Diff revision 3)

The issue has been resolved. Show all issues

Trailing whitespace (Review Bot only checks .py files, so you'll have to manually inspect the js, or enable stripping of trailing whitespace in your editor)

Diff:

Revision 4 (+74 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

Change Summary:

Address a few of the suggestions, specifically a readability improvement of the current description generator.

Diff:

Revision 5 (+76 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

reviewboard/reviews/models.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Change Summary:: Added new screencaps of progress in description panel.
Removed Files:
Added Files:

Change Summary:

Addressed whitespace for PEP8 checker.

Diff:

Revision 6 (+76 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

Change Summary:

Addressed concerns over how the input methods were not inline.

Diff:

Revision 7 (+118 -7)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

Change Summary:: Removed old input field screencaps, and added the new ones.
Removed Files:
Added Files:

File Captions:: Screen_Shot_2013-03-31_at_10.54.00_AM.png:
New input fields

Screen_Shot_2013-03-31_at_10.54.00_AM.png:	New input fields

Change Summary:: Removed WIP.
Summary:: *[WIP]* Additional Branch and Revision optional fields within Submission Banner
Additional Branch and Revision optional fields within Submission Banner

Fix it!

New description output, is this an improvement?

It's hard to tell which screenshots are of the current project. If you can remove any that don't represent the current state, that would help.

In this particular one, I'd rather not try to be smart and turn this into a big sentence. The description should be very distinct from the revision and branch.

The revision and branch should be marked up better so that they look like labels in the forms of what we have for every other field. Consistency is important here.

An issue was opened. Show all issues

It's hard to tell which screenshots are of the current project. If you can remove any that don't represent the current state, that would help.

In this particular one, I'd rather not try to be smart and turn this into a big sentence. The description should be very distinct from the revision and branch.

The revision and branch should be marked up better so that they look like labels in the forms of what we have for every other field. Consistency is important here.

Demelo March 31, 2013, 6:55 p.m.

All the screenshots are new. The old ones were deleted at the same time as these were added.

I'll look into changing it up as I was a little confused due to another comment.

Demelo March 31, 2013, 7:07 p.m.

Also, this review/comment/issue encompasses two of the previous issues. However, it seems that I am not able to comment/reply to those older review threads. Very odd. Basically, if you see one of those older review issues set to fixed, it's because their first suggestion was dealt with, but the overarching issue remains, but their reviews are not relevant anymore since this is the latest and most descriptive response.

Fix it!

New input fields

An issue was opened. Show all issues

The "(optional)" is too wordy and inconsistent from the rest of the UI. Every field is optional unless it has an asterisk, so in this case, just remove "(optional)" on these fields.

Also, I'd prefer the labels be marked up like they are on the review request fields, so that there's some visual indication.

Demelo March 31, 2013, 6:58 p.m.

By marked up, do you mean with the white background, with the 1px border, etc? At least for me, the review request fields don't seem to have a border when not in edit mode, as the actual area background is in white, hence my confusion on the matter. I'll change it to have the visualized boxes, it's a quick fix.

Change Summary:

Addressed header styling review suggestion.

Added a better looking header label set.

Diff:

Revision 8 (+123 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

Change Summary:: Removed old screencaps of header. Added newest visual of header label per the File 34 review.
Removed Files:
Added Files:

Fix it!

Newly stylized header labels.

An issue was opened. Show all issues

I meant the labels themselves, not the values. Like on a review request, how "Branch" and "Submitter" and stuff are bold and non-black. I'd suggest making the labels bold and the label color something like #333333 (dark gray).

DE

Demelo April 2, 2013, 2:35 a.m.
```
Test test.
```

Change Summary:

Addressed top banner styling suggestion.

Diff:

Revision 9 (+129 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html

Demelo April 2, 2013, 5:50 a.m.

Hmm, it's not letting me select "Fixed issue" for the issues: File 17, 18, 34, and 38.

This might be a continuation/extension of the issues I was having with my replies earlier. :/

Change Summary:

Expanded the ChangeDescription to support revision and branch tracking. Therefore, changes in submission banner will be reflected accordingly. Also, this allows for the change log restyling, and breaking up the text into each section. i.e. Revision, Branch, and a Description. 

Screencaps reflect these changes.

Diff:

Revision 10 (+130 -7)

Show changes

	reviewboard/changedescs/models.py
	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	1 more

Removed Files:

Added Files:

Change Summary:: Removing doubles.
Removed Files:

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/changedescs/models.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/reviews.less

reviewboard/reviews/models.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 56
 W291 trailing whitespace
```
reviewboard/reviews/models.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 69
 W291 trailing whitespace
```
reviewboard/reviews/models.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Col: 61
 E272 multiple spaces before keyword
```

Change Summary:

PEP8 fixes.

Diff:

Revision 11 (+130 -7)

Show changes

	reviewboard/changedescs/models.py
	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	1 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/changedescs/models.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/reviews/review_detail.html

Patch looks pretty good! Please fill in the "Testing Done" section of this review request, detailing the testing you've performed on this change.

reviewboard/static/rb/css/reviews.less (Diff revision 11)

The issue has been resolved. Show all issues

Please alphabetically order these properties, and get rid of the commented out property.

reviewboard/static/rb/css/reviews.less (Diff revision 11)
The issue has been resolved. Show all issues
```
Needs 2 space indentation here, and a space between : and inline-block.
```
reviewboard/static/rb/css/reviews.less (Diff revision 11)
The issue has been resolved. Show all issues
```
Too much indent here.
```

reviewboard/static/rb/js/reviews.js (Diff revision 11)

The issue has been resolved. Show all issues

Each of these variables need "var" in front of them.

Plus, we might as well use "revision", "branch". "desc" is fine.

reviewboard/static/rb/js/reviews.js (Diff revision 11)
The issue has been resolved. Show all issues
```
var in front of these
```
reviewboard/static/rb/js/reviews.js (Diff revision 11)
The issue has been resolved. Show all issues
```
Needs var in front of these, and use "revision" and "branch".
```
```
P
```

Change Summary:

Addressed remaining issues in tracker, which included CSS styling, javascript format, as well as a javascript fix to allow for proper javascript display of the description label area depending on if its a discarded banner or a submitted banner.

Diff:

Revision 12 (+140 -8)

Show changes

	reviewboard/changedescs/models.py
	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	1 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/changedescs/models.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/css/reviews.less

Change Summary:: Added testing done.
Testing Done:: +
THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING DISCARDED
+ - Typing nothing proceeds with empty bottom log other then signal for status change, as expected.
+
+
Take a newly published request, cursor over the Close drop down, click discarded. The discard banner appears, as expected. Typing in a reason for discard proceeds as normal.
+
+
THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING SUBMITTED
+ - Typing nothing proceeds with empty bottom log other then signal for status change, as expected.
+
+

Typing only in the description area, the text area expands, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed description under its proper heading.

+

Typing only in the revision/branch area, the text label switches to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch under its proper heading.

+

Typing in all three areas, the text labels switch to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch/description under their proper headings.

+

Typing in any of the labels as described previously, but then changing your mind and overwriting to another input. The bottomt change log adjusts to the newest version of text.

Change Summary:: Added a note to the description to address the bugged issue tracker.
Description:: Feature
- This feature adds two additional optional fields to the Submit banner alongside the original "describe your submission"; being "Revision" and Branch".
- These new fields are dynamically addressed in the change log found at the bottom of a review request.
+
+
NOTE: This review request is currently bugged, as it is not allowing the removal of the following issues from the tracker:
+ File 17, 18, 33, 34, 38. Consider these issues dealt with.

Hey Jon, I know it's late in the game, but I have two more comments.

reviewboard/static/rb/js/reviews.js (Diff revision 12)
The issue has been resolved. Show all issues
```
Remove the magic number 1, and just use Rb.ReviewRequest.CLOSE_DISCARDED.
```
1. DE
  
  Demelo April 6, 2013, 11:12 a.m.
  Fixed in Diff r13!

reviewboard/static/rb/js/reviews.js (Diff revision 12)

The issue has been resolved. Show all issues

I've just realized how fragile this is. Is jQuery.closest() not workable here?

Same with the other parent().parent().parent() bit.

DE

Demelo April 6, 2013, 12:07 p.m.
```
Fixed in Diff r14!
```

reviewboard/changedescs/models.py (Diff revision 12)

The issue has been resolved. Show all issues

I don't know that we need new fields for this. Any additional fields are supposed to lie in fields_changed.

DE

Demelo April 6, 2013, 11:14 a.m.
```
Fixed in Diff r13!
```

reviewboard/reviews/models.py (Diff revision 12)

The issue has been resolved. Show all issues

Not sure we need this. We already will be storing the information in the change description, and will be parsing it out from there. See my comment below about how we're doing that.

(If we did keep this, it'd be extremely important that the submitted_description matches the 'text' field type from ChangeDescription.)

DE

Demelo April 6, 2013, 11:14 a.m.
```
Fixed in Diff r13!
```

reviewboard/reviews/views.py (Diff revision 12)

The issue has been resolved. Show all issues

So this is completely changing how we handle these fields, and will break every existing review request out there.

The new code is saying we're going to set the descriptions from the review request, but that's not where the change description has ever lived. It's always lived in the ChangeDescription. No new review request will have change_description set on the ReviewRequest, so they'll end up with blank descriptions, losing a ton of history.

What we should do is not put this data in ReviewRequest, and instead pull from latest_changedesc, like we used to.

So, close_description should come from latest_changedesc.text.

revision should come from latest_changedesc.fields_changed['submitted_revision']['new'], if that 'submitted_revision' is in there.

Likewise, branch should come from there.

We should only pull these fields if status == ReviewRequest.SUBMITTED, since a discarded review request shouldn't have these fields.

There's also an odd naming here and elsewhere in the change. "branch_description" and "revision_description." "change_description" makes sense, because it's a description of the change, btu these are really more like "submitted_branch" and "submitted_revision."

DE

Demelo April 6, 2013, 11:14 a.m.
```
Fixed in Diff r13!
```

reviewboard/static/rb/css/reviews.less (Diff revision 12)
The issue has been resolved. Show all issues
```
This is the perfect case of where you want to target a class instead of IDs.
```
1. DE
  
  Demelo April 6, 2013, 11:14 a.m.
  Fixed in Diff r13!
reviewboard/static/rb/js/datastore.js (Diff revision 12)
The issue has been resolved. Show all issues
```
Can you just do:

    if (options.revision)

Or will that not work?
```
1. DE
  
  Demelo April 6, 2013, 12:20 p.m.
  Fixed in Diff r15!
reviewboard/static/rb/js/datastore.js (Diff revision 12)
The issue has been resolved. Show all issues
```
Why is this different from revision?
```
1. DE
  
  Demelo April 6, 2013, 12:20 p.m.
  Fixed in Diff r15!
reviewboard/static/rb/js/reviews.js (Diff revision 12)
The issue has been resolved. Show all issues
```
These are really hairy and scary. You should be able to make use of the ID for the banner.
```
1. DE
  
  Demelo April 6, 2013, 12:04 p.m.
  Fixed in Diff r14!
reviewboard/static/rb/js/reviews.js (Diff revision 12)
The issue has been resolved. Show all issues
```
Same as above.
```
1. DE
  
  Demelo April 6, 2013, 12:04 p.m.
  Fixed in Diff r14!

reviewboard/static/rb/js/reviews.js (Diff revision 12)

The issue has been resolved. Show all issues

Too much redundancy with the above. 

I think really, this entire function should be part of the above function. Any customization can be done within the function.

So, one function for any field on the banner, which will simplify the code below that calls into it, as I'll demonstrate below.

DE

Demelo April 6, 2013, 12:04 p.m.
```
Fixed in Diff r14!
```

reviewboard/static/rb/js/reviews.js (Diff revision 12)

The issue has been resolved. Show all issues

We shouldn't do this query more than once. How about:

    $('#submitted-banner .editable')
        .reviewCloseCommentEditor(RB.ReviewRequest.CLOSE_SUBMITTED);

DE

Demelo April 6, 2013, 11:14 a.m.
```
Fixed in Diff r13!
```

reviewboard/templates/reviews/review_header.html (Diff revision 12)

The issue has been resolved. Show all issues

Can we rename these IDs to "revision-description" and stuff? Using the "-". I know "changedescription" is there, but for new ones, we should fix it.

DE

Demelo April 6, 2013, 11:14 a.m.
```
Fixed in Diff r13!
```

reviewboard/webapi/resources.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Just submitted. We don't want revision or branch for the discard banner, just submitted.
```
1. DE
  
  Demelo April 6, 2013, 11:14 a.m.
  Fixed in Diff r13!
reviewboard/webapi/resources.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Should enforce that this only works for submitting.
```
1. DE
  
  Demelo April 6, 2013, 12:20 p.m.
  Fixed in Diff r15!

Change Summary:

This diff addressed the initial CSS issues in the tracker, but most importantly the full transistion from using ReviewRequest model into using the ChangeDescription changefields. Still addressing the issues involving the html scraping/javascript/jquery issues.

Diff:

Revision 13 (+137 -8)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/reviews/review_detail.html

reviewboard/reviews/models.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 13)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```

Change Summary:

Addressed the shaky jquery field pickups by replacing with stronger scraping, as well as fixed reviewCloseCommentEditor function to eliminate redundancies.

Diff:

Revision 14 (+123 -15)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/reviews/review_detail.html

reviewboard/reviews/models.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 14)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```

Change Summary:: Updated screenshots as of r13.
Removed Files:
Added Files:

Change Summary:

Addressed remaining tracker issues involving datastore.js and enforcing the .close function between submitting and discarding.

Diff:

Revision 15 (+128 -16)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/reviews/review_detail.html

reviewboard/reviews/models.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 15)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```

Change Summary:

Addressed all PEP8s that can be fixed.

Diff:

Revision 16 (+130 -16)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/reviews/review_detail.html

reviewboard/reviews/models.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 16)
The issue has been resolved. Show all issues
```
Col: 73
 W291 trailing whitespace
```
reviewboard/reviews/models.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 16)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```

Change Summary:

addressed white space pep8

Diff:

Revision 17 (+130 -16)

Show changes

	reviewboard/reviews/models.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/reviews.less
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/templates/reviews/review_detail.html
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/css/reviews.less
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/templates/reviews/review_detail.html

reviewboard/reviews/models.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (107 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 17)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```

Status:: Discarded

	+	THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING DISCARDED
	+	- Typing nothing proceeds with empty bottom log other then signal for status change, as expected.
	+
	+	Take a newly published request, cursor over the Close drop down, click discarded. The discard banner appears, as expected. Typing in a reason for discard proceeds as normal.
	+
	+	THE FOLLOWING OCCUR AFTER CURSORING OVER THE CLOSE DROP DOWN AND THEN CLICKING SUBMITTED
	+	- Typing nothing proceeds with empty bottom log other then signal for status change, as expected.
	+
	+	Typing only in the description area, the text area expands, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed description under its proper heading.
	+	Typing only in the revision/branch area, the text label switches to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch under its proper heading.
	+	Typing in all three areas, the text labels switch to edit mode, takes in input and then detracts as required. The bottom change log adjusts to display the newly typed revision/branch/description under their proper headings.
	+	Typing in any of the labels as described previously, but then changing your mind and overwriting to another input. The bottomt change log adjusts to the newest version of text.

		Feature
		- This feature adds two additional optional fields to the Submit banner alongside the original "describe your submission"; being "Revision" and Branch".
		- These new fields are dynamically addressed in the change log found at the bottom of a review request.
	+
	+	NOTE: This review request is currently bugged, as it is not allowing the removal of the following issues from the tracker:
	+	File 17, 18, 33, 34, 38. Consider these issues dealt with.