Add parent diff support to the JSON API and post-review

Review Request #396 — Created May 21, 2008 and submitted

Information

Review Board SVN (deprecated)
trunk

Reviewers

This adds support for uploading parent diffs in the JSON API, and also introduces a --parent flag to post-review for doing parent diffs on supporting repository types (currently only git-svn). It should be pretty easy to add the support to the other types.
Posted some standard diffs to make sure they didn't break. Then posted a diff with a parent diff. Saw that it uploaded as I expected.
david
  1. 
      
  2. I'd like you to add docstrings to all the diff/do_diff/etc functions that explain what this tuple is, because it's not immediately obvious except in the one case where it's actually implemented.
  3. You don't need the +; python will concatenate strings a lot like a C preprocessor.
  4. 
      
david
  1. Looks good!
  2. 
      
Loading...