Summary

[WIP] Handling many trophies

Review Request #3952 — Created March 9, 2013 and discarded March 9, 2013, 9:09 p.m.

Information

Owner

hiroki

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

[WIP] Handling many trophies

Made adding a trophy_type easier
(reviewboard/accounts/managers.py)

Testing Done

Executed unit tests.
./reviewboard/manage.py test -- reviewboard.accounts.tests:TrophyTests
./reviewboard/manage.py test -- reviewboard.reviews.tests:IfTrophyTagTests

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 9, 2013, 7:26 p.m.
Col: 34 E127 continuation line over-indented for visual indent	reviewbot	March 9, 2013, 7:26 p.m.
Col: 34 E127 continuation line over-indented for visual indent	reviewbot	March 9, 2013, 7:26 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 9, 2013, 7:26 p.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	March 9, 2013, 7:26 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 9, 2013, 7:26 p.m.
Col: 80 E501 line too long (101 > 79 characters)	reviewbot	March 9, 2013, 7:26 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 9, 2013, 7:31 p.m.
Col: 34 E127 continuation line over-indented for visual indent	reviewbot	March 9, 2013, 7:31 p.m.
Col: 34 E127 continuation line over-indented for visual indent	reviewbot	March 9, 2013, 7:31 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 9, 2013, 7:31 p.m.
Col: 41 E126 continuation line over-indented for hanging indent	reviewbot	March 9, 2013, 7:31 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 9, 2013, 7:31 p.m.
Col: 80 E501 line too long (101 > 79 characters)	reviewbot	March 9, 2013, 7:31 p.m.

Description:: [WIP] Handling many trophies

~
Made adding a trophy_type easier
~
~
Made adding a trophy_type easier
~ (reviewboard/accounts/managers.py)
-
Merge branch 'temp1' into hiroki0228

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/versionone.py
    reviewboard/reviews/tests.py
    reviewboard/settings.py
    reviewboard/admin/forms.py
    reviewboard/scmtools/tests.py
    reviewboard/reviews/models.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/accounts/managers.py
    reviewboard/urls.py
    reviewboard/webapi/tests.py
    reviewboard/accounts/models.py
    reviewboard/reviews/datagrids.py
    reviewboard/accounts/tests.py
    reviewboard/reviews/management/commands/index.py
    reviewboard/scmtools/svn.py
  Ignored Files:
    reviewboard/templates/reviews/trophy_box.html
    reviewboard/templates/reviews/review_request_box.html
    reviewboard/templates/reviews/review_issue_summary_table.html
    reviewboard/static/rb/js/views/issueSummaryTableView.js
    AUTHORS
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/views/commentDialogView.js

reviewboard/accounts/managers.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/accounts/managers.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 34
 E127 continuation line over-indented for visual indent
```
reviewboard/accounts/managers.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 34
 E127 continuation line over-indented for visual indent
```
reviewboard/accounts/managers.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/reviews/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
reviewboard/settings.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (101 > 79 characters)
```

Diff:

Revision 2 (+286 -61)

Show changes

	AUTHORS
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/managers.py
	reviewboard/accounts/models.py
	reviewboard/accounts/tests.py
	reviewboard/admin/forms.py
	reviewboard/hostingsvcs/versionone.py
	14 more

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/hostingsvcs/versionone.py
    reviewboard/reviews/tests.py
    reviewboard/settings.py
    reviewboard/admin/forms.py
    reviewboard/scmtools/tests.py
    reviewboard/reviews/models.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/accounts/managers.py
    reviewboard/urls.py
    reviewboard/webapi/tests.py
    reviewboard/accounts/models.py
    reviewboard/reviews/datagrids.py
    reviewboard/accounts/tests.py
    reviewboard/reviews/management/commands/index.py
    reviewboard/scmtools/svn.py
  Ignored Files:
    reviewboard/templates/reviews/trophy_box.html
    reviewboard/templates/reviews/review_request_box.html
    reviewboard/templates/reviews/review_issue_summary_table.html
    reviewboard/static/rb/js/views/issueSummaryTableView.js
    AUTHORS
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/views/commentDialogView.js

reviewboard/accounts/managers.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/accounts/managers.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 34
 E127 continuation line over-indented for visual indent
```
reviewboard/accounts/managers.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 34
 E127 continuation line over-indented for visual indent
```
reviewboard/accounts/managers.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/reviews/tests.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 41
 E126 continuation line over-indented for hanging indent
```
reviewboard/settings.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (101 > 79 characters)
```

Status:: Discarded

		[WIP] Handling many trophies

~		Made adding a trophy_type easier
~
	~	Made adding a trophy_type easier
	~	(reviewboard/accounts/managers.py)
-		Merge branch 'temp1' into hiroki0228

reviewboard/settings.py (Diff revision 1)

reviewboard/webapi/tests.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)

reviewboard/webapi/tests.py (Diff revision 2)