[WIP] Handling many trophies

Review Request #3952 — Created March 9, 2013 and discarded

Information

Review Board
master

Reviewers

[WIP] Handling many trophies

Made adding a trophy_type easier
(reviewboard/accounts/managers.py)
Executed unit tests.
./reviewboard/manage.py test -- reviewboard.accounts.tests:TrophyTests
./reviewboard/manage.py test -- reviewboard.reviews.tests:IfTrophyTagTests
Description From Last Updated

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 34 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 34 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 41 E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (101 > 79 characters)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 34 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 34 E127 continuation line over-indented for visual indent

reviewbotreviewbot

Col: 5 E303 too many blank lines (2)

reviewbotreviewbot

Col: 41 E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (101 > 79 characters)

reviewbotreviewbot
HI
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/versionone.py
        reviewboard/reviews/tests.py
        reviewboard/settings.py
        reviewboard/admin/forms.py
        reviewboard/scmtools/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/accounts/managers.py
        reviewboard/urls.py
        reviewboard/webapi/tests.py
        reviewboard/accounts/models.py
        reviewboard/reviews/datagrids.py
        reviewboard/accounts/tests.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/scmtools/svn.py
      Ignored Files:
        reviewboard/templates/reviews/trophy_box.html
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/templates/reviews/review_issue_summary_table.html
        reviewboard/static/rb/js/views/issueSummaryTableView.js
        AUTHORS
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/rb/js/views/commentDialogView.js
    
    
  2. reviewboard/accounts/managers.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. reviewboard/accounts/managers.py (Diff revision 1)
     
     
    Show all issues
    Col: 34
     E127 continuation line over-indented for visual indent
    
  4. reviewboard/accounts/managers.py (Diff revision 1)
     
     
    Show all issues
    Col: 34
     E127 continuation line over-indented for visual indent
    
  5. reviewboard/accounts/managers.py (Diff revision 1)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  6. reviewboard/reviews/tests.py (Diff revision 1)
     
     
    Show all issues
    Col: 41
     E126 continuation line over-indented for hanging indent
    
  7. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  8. reviewboard/webapi/tests.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (101 > 79 characters)
    
  9. 
      
HI
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/hostingsvcs/versionone.py
        reviewboard/reviews/tests.py
        reviewboard/settings.py
        reviewboard/admin/forms.py
        reviewboard/scmtools/tests.py
        reviewboard/reviews/models.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/accounts/managers.py
        reviewboard/urls.py
        reviewboard/webapi/tests.py
        reviewboard/accounts/models.py
        reviewboard/reviews/datagrids.py
        reviewboard/accounts/tests.py
        reviewboard/reviews/management/commands/index.py
        reviewboard/scmtools/svn.py
      Ignored Files:
        reviewboard/templates/reviews/trophy_box.html
        reviewboard/templates/reviews/review_request_box.html
        reviewboard/templates/reviews/review_issue_summary_table.html
        reviewboard/static/rb/js/views/issueSummaryTableView.js
        AUTHORS
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/rb/js/views/commentDialogView.js
    
    
  2. reviewboard/accounts/managers.py (Diff revision 2)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  3. reviewboard/accounts/managers.py (Diff revision 2)
     
     
    Show all issues
    Col: 34
     E127 continuation line over-indented for visual indent
    
  4. reviewboard/accounts/managers.py (Diff revision 2)
     
     
    Show all issues
    Col: 34
     E127 continuation line over-indented for visual indent
    
  5. reviewboard/accounts/managers.py (Diff revision 2)
     
     
    Show all issues
    Col: 5
     E303 too many blank lines (2)
    
  6. reviewboard/reviews/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 41
     E126 continuation line over-indented for hanging indent
    
  7. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (80 > 79 characters)
    
  8. reviewboard/webapi/tests.py (Diff revision 2)
     
     
    Show all issues
    Col: 80
     E501 line too long (101 > 79 characters)
    
  9. 
      
HI
Review request changed
Status:
Discarded