Convert RB.ReviewReply to Backbone.

Review Request #3950 — Created March 8, 2013 and submitted

david
Review Board
master
reviewboard
Convert RB.ReviewReply to Backbone.

This is another relatively simple conversion for the data model for ReviewReply
objects to be based on BaseResource.
Replied to an existing review with body_top, body_bottom, and children
CommentReply objects. Published that reply and saw it get saved correctly.
Verified that loading a draft reply worked as expected. Ran js-tests.
Description From Last Updated

Should be bodyTop/bodyBottom.

chipx86chipx86
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/rb/js/datastore.js
        reviewboard/static/rb/js/models/tests/reviewReplyModelTests.js
        reviewboard/static/rb/js/models/reviewReplyModel.js
    
    
  2. 
      
chipx86
  1. Looks great. One small thing.
  2. Should be bodyTop/bodyBottom.
    1. I started to do that initially, but the form with the underscore is pretty pervasive, and I'd end up translating back and forth from underscores to camelCase in several places. I think it'll be easier to change this later once Review is also converted.
    2. Okay, in that case, can you add a TODO? I'd like to be consistent and use camelCase in the end.
  3. reviewboard/static/rb/js/reviews.js (Diff revision 1)
     
     
     
    Do we need this? Between the error banner and the Network tab in Chrome/Firefox, we should be able to see what went wrong.
  4. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
        reviewboard/static/rb/js/datastore.js
        reviewboard/static/rb/js/models/tests/reviewReplyModelTests.js
        reviewboard/static/rb/js/models/reviewReplyModel.js
    
    
  2. 
      
chipx86
  1. If you can add a TODO to rename them first, that will help to remember when the rest gets ported over.
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (0a0cc93).
Loading...