Summary

Convert RB.ReviewReply to Backbone.

Review Request #3950 — Created March 8, 2013 and submitted March 13, 2013, 12:13 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Convert RB.ReviewReply to Backbone.

This is another relatively simple conversion for the data model for ReviewReply
objects to be based on BaseResource.

Testing Done

Replied to an existing review with body_top, body_bottom, and children
CommentReply objects. Published that reply and saw it get saved correctly.
Verified that loading a draft reply worked as expected. Ran js-tests.

Issues

Description	From	Last Updated
Should be bodyTop/bodyBottom.	chipx86	March 9, 2013, 5:15 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/datastore.js
    reviewboard/static/rb/js/models/tests/reviewReplyModelTests.js
    reviewboard/static/rb/js/models/reviewReplyModel.js

```
Looks great. One small thing.
```

reviewboard/static/rb/js/models/reviewReplyModel.js (Diff revision 1)

The issue has been dropped. Show all issues

Should be bodyTop/bodyBottom.

david March 9, 2013, 5:16 p.m.

I started to do that initially, but the form with the underscore is pretty pervasive, and I'd end up translating back and forth from underscores to camelCase in several places. I think it'll be easier to change this later once Review is also converted.

chipx86 March 10, 2013, 1:35 a.m.

Okay, in that case, can you add a TODO? I'd like to be consistent and use camelCase in the end.

reviewboard/static/rb/js/reviews.js (Diff revision 1)

Do we need this? Between the error banner and the Network tab in Chrome/Firefox, we should be able to see what went wrong.

Diff:

Revision 2 (+113 -171)

Show changes

	reviewboard/settings.py
	reviewboard/static/rb/js/datastore.js
	reviewboard/static/rb/js/reviews.js
	reviewboard/static/rb/js/models/reviewReplyModel.js
	reviewboard/static/rb/js/models/tests/reviewReplyModelTests.js

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/settings.py
  Ignored Files:
    reviewboard/static/rb/js/reviews.js
    reviewboard/static/rb/js/datastore.js
    reviewboard/static/rb/js/models/tests/reviewReplyModelTests.js
    reviewboard/static/rb/js/models/reviewReplyModel.js

Ship it!

If you can add a TODO to rename them first, that will help to remember when the rest gets ported over.

Status: Closed (submitted)

Change Summary:

Pushed to master (0a0cc93).