Convert RB.Screenshot to Backbone.
Review Request #3947 — Created March 7, 2013 and submitted
Convert RB.Screenshot to Backbone. This is a fairly trivial change to migrate the old screenshot object to Backbone.js. The only tricky part of this is that I had to add an indirection step to BaseResourceModel to ensure that the parent object is loaded before calling url(), because if we don't have the parent links, we won't have a URL for the object.
Tested setting screenshot captions and deleting screenshots. Ran js-tests.
Change Summary:
Get rid of unused properties. None of these matter anymore since we can't create new screenshots.
Diff: |
Revision 2 (+77 -172) |
|---|
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/reviews.js reviewboard/static/rb/js/datastore.js reviewboard/static/rb/js/models/tests/screenshotModelTests.js reviewboard/static/rb/js/models/screenshotModel.js reviewboard/static/rb/js/models/baseResourceModel.js
-
-
reviewboard/static/rb/js/models/screenshotModel.js (Diff revision 2) Should extend RB.BaseResource.prototype.defaults.
-
-
reviewboard/static/rb/js/reviews.js (Diff revision 2) Do we want to show this immediately, or when we know we successfully destroyed?
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/reviews.js reviewboard/static/rb/js/datastore.js reviewboard/static/rb/js/models/tests/screenshotModelTests.js reviewboard/static/rb/js/models/screenshotModel.js reviewboard/static/rb/js/models/baseResourceModel.js
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/static/rb/js/reviews.js reviewboard/static/rb/js/datastore.js reviewboard/static/rb/js/models/tests/screenshotModelTests.js reviewboard/static/rb/js/models/screenshotModel.js reviewboard/static/rb/js/models/baseResourceModel.js