Unedited p4 files caused server side stacktraces

Review Request #3944 — Created March 7, 2013 and submitted

Information

RBTools

Reviewers

If you make a perforce-backed code review with an unedited (but opened) file
then ReviewBoard chokes on the empty diff content. Based on the recentness of
this issue I suspect that it's regression for us from upgrading ReviewBoard
from 1.5 to 1.6. 

This issue has been discussed by others on...

http://code.google.com/p/reviewboard/issues/detail?id=2754

========================================

Steps to repro:

1. p4 edit some/file/with/stuff
2. run postreview

Expected:

Post-review should error out if you don't have any edits. If you have other
modifications then it should just make a code review with that.

Actual:

Post-review always succeeds, but the unedited file renders as a stacktrace in
ReviewBoard.


This can be pulled from my issue2754 branch...

https://github.com/atagar/rbtools/tree/issue2754
This was tested on an older version of post-review by both...

* creating a code review where the only opened file was unedited (post-review now properly tells you "There don't seem to be any diffs!")
* mixed with other changes, the code review is still made but now excludes the unedited file
Description From Last Updated

Col: 80 E501 line too long (88 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (88 > 79 characters)
    
  3. 
      
AT
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        rbtools/clients/perforce.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
AT
Review request changed
Status:
Completed
Change Summary:
Pushed to master (74d0a42).