Move the diff fragment loading into the new DiffViewer model.

Review Request #3934 — Created March 5, 2013 and submitted

Information

Review Board
master

Reviewers

Move the diff fragment loading into the new DiffViewer model.

This introduces RB.DiffViewer, which replaces and consolidates our old
diff fragment loading code. It cleans up the API a little and removes a
bunch of redundancy. It also simplifies RB.Diff, which was previously
doing too many different things.

This will later be used to store additional state of the diff viewer,
when that's ported over to use Backbone.
Loaded some diffs (both standard diffs and interdiffs), and expanded chunks.

Unit tests pass.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/settings.py
      Ignored Files:
        reviewboard/static/rb/js/models/diffReviewableModel.js
        reviewboard/static/rb/js/datastore.js
        reviewboard/static/rb/js/models/baseResourceModel.js
        reviewboard/static/rb/js/utils/underscoreUtils.js
        reviewboard/static/rb/js/diffviewer.js
        reviewboard/static/rb/js/models/tests/diffReviewableModelTests.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...