This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py Ignored Files: reviewboard/templates/js/tests.html reviewboard/static/rb/js/models/tests/reviewGroupModelTests.js reviewboard/templates/base.html reviewboard/static/rb/js/datastore.js reviewboard/static/rb/js/models/tests/userSessionModelTests.js reviewboard/static/rb/js/models/baseResourceModel.js reviewboard/static/rb/js/models/tests/reviewRequestModelTests.js reviewboard/static/rb/js/models/reviewGroupModel.js reviewboard/static/rb/js/common.js reviewboard/static/rb/js/models/userSessionModel.js
Add a new UserSession model, and redo support for starring.
Review Request #3929 — Created March 5, 2013 and submitted
Add a new UserSession model, and redo support for starring. This introduces a UserSession model, which is a singleton that represents the user's session. It is intended to replace gUsername, and to provide the API for handling the watched groups/review requests. The ReviewGroup model has been rewritten to be on Backbone.js and to make use of this new API. The existing ReviewRequest code now uses this API as well. Unit tests were added to test the basic UserSession singleton logic, and the individual setStarred functions.
All unit tests pass. Went around starring and unstarring groups and review requests, looking at debug output to make sure the new code was being called. Verified that the changes saved on the server.