Allow to specify in which port MySQL is running when creating a new rb site

Review Request #3923 — Created Feb. 27, 2013 and submitted

Information

Review Board

Reviewers

Allow to specify in which port MySQL is running when creating a new rb site. Currently if database hostname is used (instead of socket) the port option is not working correctly. There is a comment in the code mentioning that in that when MySQL is running in a non default port db_hostname can be specified with hostname:port format. That doesn't seem to work. I have added the new --db_port option instead.
Tested with default and not default ports for MySQL. With this option the settings_local.py file is created correctly and the databases are created.
Description From Last Updated

Col: 80 E501 line too long (90 > 79 characters)

reviewbotreviewbot

Col: 24 E127 continuation line over-indented for visual indent

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/cmdline/rbsite.py
      Ignored Files:
    
    
  2. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (90 > 79 characters)
    
  3. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Show all issues
    Col: 24
     E127 continuation line over-indented for visual indent
    
  4. 
      
KA
KA
chipx86
  1. Hi Victoria,
    
    I'm hoping we can avoid needing to ask the user for another bit of information. Can we instead change what the DB host accepts to take a port? So instead of just "localhost", "locahost:1234" would be allowed?
    1. Update. The issue (not accepting the port) is only found when --noinput option is specified. When this option is not used db-host:db-port format was working.
  2. 
      
KA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/cmdline/rbsite.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Looks good. How do you want to be referenced in the AUTHORS file?
    1. BitNami if possible, if not you can use Victoria Ponce. Thanks!
  2. 
      
KA
Review request changed
Status:
Completed
Change Summary:
Pushed to release-1.7.x (b633e13)