Summary

Allow to specify in which port MySQL is running when creating a new rb site

Review Request #3923 — Created Feb. 27, 2013 and submitted April 19, 2013, 10:24 p.m.

Information

Owner

kaysa

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Allow to specify in which port MySQL is running when creating a new rb site. Currently if database hostname is used (instead of socket) the port option is not working correctly. There is a comment in the code mentioning that in that when MySQL is running in a non default port db_hostname can be specified with hostname:port format. That doesn't seem to work. I have added the new --db_port option instead.

Testing Done

Tested with default and not default ports for MySQL. With this option the settings_local.py file is created correctly and the databases are created.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Feb. 27, 2013, 1:29 a.m.
Col: 24 E127 continuation line over-indented for visual indent	reviewbot	Feb. 27, 2013, 1:29 a.m.

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/cmdline/rbsite.py
  Ignored Files:

reviewboard/cmdline/rbsite.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```

reviewboard/cmdline/rbsite.py (Diff revision 1)

Show all issues

Col: 24
 E127 continuation line over-indented for visual indent

Testing Done:

Tested with default and not default ports for MySQL. With this option the settings_local.py file is created correctly and the databases are created.

Hi Victoria,

I'm hoping we can avoid needing to ask the user for another bit of information. Can we instead change what the DB host accepts to take a port? So instead of just "localhost", "locahost:1234" would be allowed?

kaysa March 4, 2013, 2:40 a.m.

Update. The issue (not accepting the port) is only found when --noinput option is specified. When this option is not used db-host:db-port format was working.

Change Summary:

Removed new --db-port option. Accept <db_host>:<db_port> format for the database hostname also when --noinput option is used.

Diff:

Revision 2 (+4 -6)

Show changes

reviewboard/cmdline/rbsite.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/cmdline/rbsite.py
  Ignored Files:

Ship it!

Looks good. How do you want to be referenced in the AUTHORS file?

kaysa March 15, 2013, 2:32 a.m.

BitNami if possible, if not you can use Victoria Ponce. Thanks!

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (b633e13)