Summary

Convert the svn hook to new api

Review Request #3909 — Created Feb. 24, 2013 and submitted Feb. 25, 2013, 11:22 p.m.

Information

Owner

mvanbaak

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

the svn commit hook to set a review request submitted only worked with the pre 1.6 api.
This patch makes it work with the new api.

It drops support for the old api.

Testing Done

Tested on my private setup with reviewboard 1.7.4 and subversion 1.7

Issues

Description	From	Last Updated
Can you wrap this line to 80 characters?	david	Feb. 25, 2013, 4:40 a.m.
This can all be on one line.	david	Feb. 25, 2013, 4:22 a.m.
There's some trailing whitespace here.	david	Feb. 25, 2013, 4:22 a.m.
This can all be on one line.	david	Feb. 25, 2013, 4:22 a.m.
All one line.	david	Feb. 25, 2013, 4:22 a.m.
Here too.	david	Feb. 25, 2013, 4:22 a.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/tools/svn-hook-set-submitted

contrib/tools/svn-hook-set-submitted (Diff revision 1)
Show all issues
```
Can you wrap this line to 80 characters?
```
contrib/tools/svn-hook-set-submitted (Diff revision 1)
Show all issues
```
This can all be on one line.
```
contrib/tools/svn-hook-set-submitted (Diff revision 1)
Show all issues
```
There's some trailing whitespace here.
```
contrib/tools/svn-hook-set-submitted (Diff revision 1)
Show all issues
```
This can all be on one line.
```
contrib/tools/svn-hook-set-submitted (Diff revision 1)
Show all issues
```
All one line.
```
contrib/tools/svn-hook-set-submitted (Diff revision 1)
Show all issues
```
Here too.
```

Change Summary:

update based on feedback.

Branch:

+	master

Diff:

Revision 2 (+67 -41)

Show changes

contrib/tools/svn-hook-set-submitted

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/tools/svn-hook-set-submitted

Change Summary:

remove trailing whitespace

Diff:

Revision 3 (+67 -41)

Show changes

contrib/tools/svn-hook-set-submitted

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    contrib/tools/svn-hook-set-submitted

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (4159f3d). Thanks!