Summary

gracefully handle no-match in p4 info regex

Review Request #3902 — Created Feb. 21, 2013 and submitted Feb. 24, 2013, 2:04 p.m.

Information

Owner

deleted-user-8F1D1287

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

If the regular expression doesn't parse the string that p4 info returns, calling group will cause a traceback.  This came up where p4 info returned an unexpected string.

Testing Done

Manual testing with the p4 binary that returned a non-standard string.  I'm on OSX and I'm not going to spend the non-trivial time to get unit tests running.  No hard feelings if you reject this patch on that basis.

Issues

Description	From	Last Updated
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 21, 2013, 5:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2013, 5:13 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 21, 2013, 5:18 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 21, 2013, 5:18 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/perforce.py
  Ignored Files:

rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```

Change Summary:

fix whitespace

Diff:

Revision 2 (+4 -1)

Show changes

rbtools/clients/perforce.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/perforce.py
  Ignored Files:

rbtools/clients/perforce.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/clients/perforce.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```

Change Summary:

fix whitespace??

Diff:

Revision 3 (+4 -1)

Show changes

rbtools/clients/perforce.py

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    rbtools/clients/perforce.py
  Ignored Files:

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (124cb39). Thanks!

rbtools/clients/perforce.py (Diff revision 1)

rbtools/clients/perforce.py (Diff revision 1)

rbtools/clients/perforce.py (Diff revision 2)

rbtools/clients/perforce.py (Diff revision 2)