-
-
rbtools/clients/perforce.py (Diff revision 1) Col: 1 E101 indentation contains mixed spaces and tabs
-
gracefully handle no-match in p4 info regex
Review Request #3902 — Created Feb. 21, 2013 and submitted
If the regular expression doesn't parse the string that p4 info returns, calling group will cause a traceback. This came up where p4 info returned an unexpected string.
Manual testing with the p4 binary that returned a non-standard string. I'm on OSX and I'm not going to spend the non-trivial time to get unit tests running. No hard feelings if you reject this patch on that basis.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/clients/perforce.py Ignored Files:
-
-
rbtools/clients/perforce.py (Diff revision 2) Col: 1 E101 indentation contains mixed spaces and tabs