*[WIP]* Dependencies - Admin Panel only

Review Request #3876 — Created Feb. 16, 2013 and discarded

Demelo
Review Board
master
281
reviewboard
Demelo
Dependency WIP Submission Commit

EDIT: Due to some suggestions during the meeting, this submission
ended up being generally for learning how to submit a request
more so than a WIP delivery. This is because the suggestions
have me touching/adjusting the core of these changes.

This commit has the task to a point where a user is able to add
dependencies of drafts and published requests to a review by
means of the Admin panel, and view these dependencies within a
review request panel. At this moment, the blocking reverse
dependency feature is in an early phase, and the front-end means
of dependency interactions are in planning stages.


Description From Last Updated

Col: 62 W291 trailing whitespace

reviewbotreviewbot

Col: 68 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (93 > 79 characters)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 69 W291 trailing whitespace

reviewbotreviewbot

Col: 80 E501 line too long (81 > 79 characters)

reviewbotreviewbot

Col: 69 W291 trailing whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 67 W291 trailing whitespace

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 46 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 48 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 59 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 61 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 53 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 55 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 53 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 55 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 52 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 54 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 67 W291 trailing whitespace

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 46 E251 no spaces around keyword / parameter equals

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 41 E128 continuation line under-indented for visual indent

reviewbotreviewbot
DE
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/webapi/resources.py
        reviewboard/reviews/models.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/datagrids.py
      Ignored Files:
        reviewboard/static/rb/js/reviews.js
        reviewboard/templates/reviews/review_request_box.html
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 71.
  2. reviewboard/reviews/admin.py (Diff revision 1)
     
     
    Col: 62
     W291 trailing whitespace
    
  3. reviewboard/reviews/admin.py (Diff revision 1)
     
     
    Col: 68
     W291 trailing whitespace
    
  4. reviewboard/reviews/admin.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (93 > 79 characters)
    
  5. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  6. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 69
     W291 trailing whitespace
    
  7. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (81 > 79 characters)
    
  8. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 69
     W291 trailing whitespace
    
  9. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 1
     W293 blank line contains whitespace
    
  10. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 67
     W291 trailing whitespace
    
  11. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  12. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 46
     E251 no spaces around keyword / parameter equals
    
  13. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 48
     E251 no spaces around keyword / parameter equals
    
  14. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 59
     E251 no spaces around keyword / parameter equals
    
  15. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 61
     E251 no spaces around keyword / parameter equals
    
  16. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  17. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 53
     E251 no spaces around keyword / parameter equals
    
  18. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 55
     E251 no spaces around keyword / parameter equals
    
  19. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  20. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 53
     E251 no spaces around keyword / parameter equals
    
  21. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 55
     E251 no spaces around keyword / parameter equals
    
  22. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  23. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 52
     E251 no spaces around keyword / parameter equals
    
  24. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 54
     E251 no spaces around keyword / parameter equals
    
  25. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 67
     W291 trailing whitespace
    
  26. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  27. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 46
     E251 no spaces around keyword / parameter equals
    
  28. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  29. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  30. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  31. reviewboard/reviews/models.py (Diff revision 1)
     
     
    Col: 41
     E128 continuation line under-indented for visual indent
    
  32. 
      
DE
DE
DE
Review request changed

Status: Discarded

Change Summary:

was for testing purposes only.
Loading...