*[WIP]* Dependencies - Admin Panel only
Review Request #3876 — Created Feb. 16, 2013 and discarded
Dependency WIP Submission Commit EDIT: Due to some suggestions during the meeting, this submission ended up being generally for learning how to submit a request more so than a WIP delivery. This is because the suggestions have me touching/adjusting the core of these changes. This commit has the task to a point where a user is able to add dependencies of drafts and published requests to a review by means of the Admin panel, and view these dependencies within a review request panel. At this moment, the blocking reverse dependency feature is in an early phase, and the front-end means of dependency interactions are in planning stages.
| Description | From | Last Updated |
|---|---|---|
|
Col: 62 W291 trailing whitespace |
 reviewbot
|
|
|
Col: 68 W291 trailing whitespace |
reviewbot
|
|
|
Col: 80 E501 line too long (93 > 79 characters) |
reviewbot
|
|
|
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
Col: 69 W291 trailing whitespace |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Col: 69 W291 trailing whitespace |
reviewbot
|
|
|
Col: 1 W293 blank line contains whitespace |
reviewbot
|
|
|
Col: 59 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 61 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 48 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 46 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 67 W291 trailing whitespace |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 53 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 55 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 53 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 55 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 52 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 54 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 67 W291 trailing whitespace |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 46 E251 no spaces around keyword / parameter equals |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot
|
DE
- Change Summary:
-
Little edit of the desc.
- Description:
-
Dependency WIP Submission Commit
EDIT: Due to some suggestions during the meeting, this submission
ended up being generally for learning how to submit a request more so than a WIP delivery. This is because the suggestions have me touching/adjusting the core of these changes. This commit has the task to a point where a user is able to add
dependencies of drafts and published requests to a review by ~ means of the Admin panel. At this moment, the blocking reverse ~ means of the Admin panel, and view these dependencies within a + review request panel. At this moment, the blocking reverse dependency feature is in an early phase, and the front-end means of dependency interactions are in planning stages. saving to external
Lots of changes. Fun stuff. :)
Multiple Additions in relation to Dependancy.
The current goal is to achieve a working set of two
date fields, 1st: Depends on Drafts, and 2nd: Depends on Published. Once these two fields are working as required, the goal will then be to properly infuse them together to display as a single representation for the user. Initial admin panel and webapi features added, more to follow.
Today I was able to delve into the /reviews/admin.py, and I was able
to set up an initial representation of the relationships within the admin panel. It’s full functionality is still waiting on the web API connections to be completed, but that will be referenced later. Next, I was able to jump into the /reviews/views.py, and begin to
really research the inner workings of ReviewBoard. I was able to significantly improve my understandings of both the Django view framework and how it relates to this project, so it’s looking quite promising for now. This new perspective allowed me to finally delve head first into the
monster that is the /webapi/resources.py file, and I was able to do some initial progress adding the dependencies into the whole mix. Specifically, I was able to contribute to the _set_draft_field_data function within the ReviewRequestDraftResource class, adding in the dependencies. stashing changes for merge
Moved Depends On once more to the parent class BaseReviewRequestDetails to reduce redundency.
Moved the Depends On M2M relationships from their own model(s) to within the ReviewRequest and ReviewRequestDraft models.
Models for Depends On feature have been added to reviews/models.py
Specifically, the ManyToMany relationships between Draft ->
(Draft/Published) and Published -> (Draft/Published) have been mapped. The Depends On project is now at a stage where the visual front end
is prepped, and the database modelling has been initially completed. Front-end edits to the new review request box.
Specifically, the Depends On and Blocks edit fields have been added
and the submitter heading has been moved to the summary panel above.
DE
- Change Summary:
-
removed old commits in desc.
- Description:
-
Dependency WIP Submission Commit
EDIT: Due to some suggestions during the meeting, this submission
ended up being generally for learning how to submit a request more so than a WIP delivery. This is because the suggestions have me touching/adjusting the core of these changes. This commit has the task to a point where a user is able to add
dependencies of drafts and published requests to a review by means of the Admin panel, and view these dependencies within a review request panel. At this moment, the blocking reverse dependency feature is in an early phase, and the front-end means of dependency interactions are in planning stages. - - saving to external
- - - - Lots of changes. Fun stuff. :)
- - - - Multiple Additions in relation to Dependancy.
- - The current goal is to achieve a working set of two
- date fields, 1st: Depends on Drafts, and 2nd: Depends on Published. - Once these two fields are working as required, the goal will then be - to properly infuse them together to display as a single representation - for the user. - - Initial admin panel and webapi features added, more to follow.
- - Today I was able to delve into the /reviews/admin.py, and I was able
- to set up an initial representation of the relationships within the - admin panel. It’s full functionality is still waiting on the web API - connections to be completed, but that will be referenced later. - - Next, I was able to jump into the /reviews/views.py, and begin to
- really research the inner workings of ReviewBoard. I was able to - significantly improve my understandings of both the Django view - framework and how it relates to this project, so it’s looking quite - promising for now. - - This new perspective allowed me to finally delve head first into the
- monster that is the /webapi/resources.py file, and I was able to do - some initial progress adding the dependencies into the whole mix. - Specifically, I was able to contribute to the _set_draft_field_data - function within the ReviewRequestDraftResource class, adding in the - dependencies. - - stashing changes for merge
- - - - Moved Depends On once more to the parent class BaseReviewRequestDetails to reduce redundency.
- - - - Moved the Depends On M2M relationships from their own model(s) to within the ReviewRequest and ReviewRequestDraft models.
- - - - Models for Depends On feature have been added to reviews/models.py
- - Specifically, the ManyToMany relationships between Draft ->
- (Draft/Published) and Published -> (Draft/Published) have been - mapped. - - The Depends On project is now at a stage where the visual front end
- is prepped, and the database modelling has been initially completed. - - Front-end edits to the new review request box.
- - Specifically, the Depends On and Blocks edit fields have been added
- and the submitter heading has been moved to the summary panel above.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/webapi/resources.py reviewboard/reviews/models.py reviewboard/reviews/admin.py reviewboard/reviews/datagrids.py Ignored Files: reviewboard/static/rb/js/reviews.js reviewboard/templates/reviews/review_request_box.html WARNING: Number of comments exceeded maximum, showing 30 of 71.