Add ExtensionHook for User Pages
Review Request #3875 — Created Feb. 16, 2013 and submitted
| Information | |
|---|---|
| rajasaur | |
| Review Board | |
| Reviewers | |
| reviewboard | |
Add support for extensions in UserPage
This patch adds support for adding extensions in UserPage and works very similar to the DashboardHook. It takes a dictionary of label, url and an optional subitems -- which itself can be an array of (label,url) -- to add custom links in the /users/<username> page.
Also updated the documentation page to indicate the usage of this. Im not sure how to build the doc page into html, so the formatting hasnt been checked for the new documentation.
I added support for this hook so that people wanting to build user-specific reports can use this. For e.g. reports like review-requests assigned to me, or a users' RSS feed can all be linked directly from a user page.
Ran all existing tests. Added a new test for the UserPageHook. Added a new test extension that demonstrates the use of this (Screenshot attached). Tested without extension to ensure no other breakage.
| Description | From | Last Updated |
|---|---|---|
|
There's some trailing whitespace here and elsewhere in the file. |
 chipx86
|
|
|
It's possible we'd want to add other sorts of hooks to this page (such as a banner of some sort … |
chipx86
|
|
|
Let's see an example with subitems too. |
 mike_conley
|
|
|
Nit - let's put these in alphabetical ordering. |
mike_conley
|
|
|
Looks like all the newly introduced tags should be indented by 1 space (to be relative to the endif). The … |
chipx86
|
RA
Description: |
|
|---|
-
-
docs/codebase/extending/extensions.txt (Diff revision 1) There's some trailing whitespace here and elsewhere in the file.
-
reviewboard/extensions/hooks.py (Diff revision 1) It's possible we'd want to add other sorts of hooks to this page (such as a banner of some sort above the list of review requests). That may make this name confusing. I think a more fitting name would be UserPageSidebarHook.
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/codebase/extending/extensions.txt reviewboard/templates/reviews/user_page.html
-
I'm quite happy with this change. Just two suggestions, and then I'll give my ship-it. Thanks for the excellent patch!
-
-
-
-
reviewboard/templates/reviews/user_page.html (Diff revision 2) Looks like all the newly introduced tags should be indented by 1 space (to be relative to the endif). The other tags in this file are all pretty off. Even that endif should really be indented by 2. Oh well.. Might as well get a little closer to correct.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/codebase/extending/extensions.txt reviewboard/templates/reviews/user_page.html