Introduce the status command
Review Request #3865 — Created Feb. 11, 2013 and submitted
| Information | |
|---|---|
| smacleod | |
| RBTools | |
| master | |
| Reviewers | |
| rbtools | |
| chipx86 | |
Introduce the status command The status command will display the id and summary of each pending review request a user has. Also, the get_root method has been renamed get_api and will now return the RBClient instance along with the root resource. This allows commands to receive direct access to the API client which can be useful if they need to update login information after instantiating the client. A few of the commands have also been updated to make less requests to the Review Board server by taking advantage of the uri templates on the root resource.
Ran commands, used rbt status to check review requests.
| Description | From | Last Updated |
|---|---|---|
|
Can we add a docstring for this? Also, assuming this is a private function, we should provide an underscore (and … |
 chipx86
|
|
|
Might as well include self.get_cookie() right here. |
chipx86
|
|
|
Should this be the same thing? Can we bail out any other way than StopIteration? |
chipx86
|
|
|
Blank line between these. |
chipx86
|
|
|
This seems like something worth having in a common place. |
chipx86
|
|
|
Should probably be a period before and after "Please login" |
chipx86
|
|
|
Does this get outputted in non-debug situations? If so, we should make sure it wraps at 80. |
chipx86
|
|
|
Excess blank line. |
chipx86
|
|
|
"Review Board" |
chipx86
|
|
|
"auth_required" |
chipx86
|
-
-
rbtools/commands/__init__.py (Diff revision 1) Can we add a docstring for this? Also, assuming this is a private function, we should provide an underscore (and stick it at the end of the class). Should this be _make_api_client? Calling it more than once would give different results.
-
-
rbtools/commands/status.py (Diff revision 1) Should this be the same thing? Can we bail out any other way than StopIteration?
-
-
rbtools/commands/status.py (Diff revision 1) This seems like something worth having in a common place.
-
rbtools/commands/status.py (Diff revision 1) Should probably be a period before and after "Please login"
-
rbtools/commands/status.py (Diff revision 1) Does this get outputted in non-debug situations? If so, we should make sure it wraps at 80.
-
SM
Change Summary:
Updated based on Christian's review
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+208 -63) |
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py rbtools/api/client.py rbtools/commands/__init__.py rbtools/commands/close.py rbtools/commands/patch.py rbtools/commands/post.py rbtools/commands/attach.py rbtools/commands/publish.py setup.py rbtools/utils/users.py Ignored Files:
-
-
-
rbtools/commands/patch.py (Diff revision 2) Can this be done in a common place so that all commands can get it for free?
-
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py rbtools/api/client.py rbtools/commands/publish.py rbtools/commands/close.py rbtools/commands/patch.py rbtools/commands/post.py rbtools/commands/attach.py rbtools/commands/__init__.py setup.py rbtools/utils/users.py Ignored Files:
-
Found a typo. After that, ship it!
-
-
rbtools/utils/users.py (Diff revision 3) Eventually we should find a way to handle this without assuming raw input, but that's for another day.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: rbtools/commands/status.py setup.py rbtools/commands/__init__.py Ignored Files: