Always allow users to access their own review requests.

Review Request #3845 — Created Feb. 6, 2013 and submitted

david
Review Board
release-1.7.x
2446
reviewboard
Always allow users to access their own review requests.

In cases where a user assigned a review request to a private group of which they
were not a member, they'd lose access to their own request. This was pretty bad.
I've added an explicit check for ownership to ensure that users always have
access to their own review requests.
Created a review as a non-admin user and assigned it to a private review group.
Saw that I could no longer access it. Applied this change and reloaded, and saw
that I could see it again. New unit test fails before the change and succeeds
after.
Description From Last Updated

There should be a period on the end.

SM smacleod

Col: 80 E501 line too long (98 > 79 characters)

reviewbotreviewbot
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/models.py
      Ignored Files:
    
    
  2. 
      
chipx86
  1. Looks good. Can we get a unit test for this though, to make sure it never breaks again?
  2. 
      
david
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/tests.py
        reviewboard/reviews/models.py
      Ignored Files:
    
    
  2. reviewboard/reviews/tests.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (98 > 79 characters)
    
  3. 
      
SM
  1. Other than the period, looks good to me.
  2. reviewboard/reviews/models.py (Diff revision 2)
     
     
    There should be a period on the end.
  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (b0500a8).
Loading...