Always allow users to access their own review requests.
Review Request #3845 — Created Feb. 6, 2013 and submitted
Always allow users to access their own review requests. In cases where a user assigned a review request to a private group of which they were not a member, they'd lose access to their own request. This was pretty bad. I've added an explicit check for ownership to ensure that users always have access to their own review requests.
Created a review as a non-admin user and assigned it to a private review group. Saw that I could no longer access it. Applied this change and reloaded, and saw that I could see it again. New unit test fails before the change and succeeds after.
| Description | From | Last Updated |
|---|---|---|
|
There should be a period on the end. |
SM smacleod | |
|
Col: 80 E501 line too long (98 > 79 characters) |
 reviewbot
|
- Change Summary:
-
Add a unit test
- Description:
-
Always allow users to access their own review requests.
In cases where a user assigned a review request to a private group of which they
were not a member, they'd lose access to their own request. This was pretty bad. I've added an explicit check for ownership to ensure that users always have access to their own review requests. - Testing Done:
-
Created a review as a non-admin user and assigned it to a private review group.
Saw that I could no longer access it. Applied this change and reloaded, and saw ~ that I could see it again. ~ that I could see it again. New unit test fails before the change and succeeds + after.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/models.py Ignored Files: