Search box: Jump to Users/reviewrequests does not work in 1.7

Review Request #3835 — Created Feb. 5, 2013 and submitted

rajasaur
Review Board
2842, 2887
reviewboard
Clicking on the auto-completed search results does not take the user to review-request/user/group. This seems to have been changed in commit 937d9c0 (https://github.com/rajasaur/reviewboard/commit/937d9c098f21e3619691e8d63726b41aea4809aa) to avoid collision with jquery ui's version but seems to have
removed this logic.

Ive added the logic that takes the user to the page when its clicked from the Search box. In addition, Ive also set the default value of "clickToURL" to
false so that other autocompletes like the ones in review page (for user/group) dont automatically take the user to that page when clicked.

What still doesnt work:
1. Just clicking on "enter" key on auto-completed results doesnt take the user to the result page. It only fills in the Search box. But I suppose thats another issue (bug 2779).
1. Tested in Search page by entering review-request/users and made sure it goes to the correct page
2. Verified in the Review request page that selecting a user/group does not open a new page but instead places the users in the required textfield.
Description From Last Updated

These should be on the same line.

daviddavid

Space in between // and F

daviddavid

This was already a long line, but can you split this onto multiple lines and try to wrap to 80 ...

daviddavid
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/lib/js/ui.autocomplete.js
    
    
  2. 
      
david
  1. 
      
  2. These should be on the same line.
  3. Space in between // and F
  4. This was already a long line, but can you split this onto multiple lines and try to wrap to 80 columns? Something like this:
    
    var li = makeItem(data[i].data)
        .html(options.highlight(formatted, term))
        .addClass(...)
        ...
  5. 
      
RA
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
      Ignored Files:
        reviewboard/static/lib/js/ui.autocomplete.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
RA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (2b15703). Thanks!
Loading...