Summary

Fix a regression with displaying diff viewer file entries.

Review Request #3820 — Created Jan. 30, 2013 and submitted Jan. 30, 2013, 11:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix a regression with displaying diff viewer file entries.

The "Files Changed" list in the diff viewer broke with Windows-style
paths. A previous change was made to fix a JavaScript injection issue,
but that caused some escaping issues when using backslashes. We now
escape both HTML and JavaScript.

Testing Done

Added some entries with backslashes, and added one with a <script>alert('...')</script>.
All were escaped as expected.

Expand All
Collapse All

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/templates/diffviewer/changeindex_entry.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (7624aeeff77dd019c40915410a5d81b7c55752ae)