Summary

Added nice styling of diffs in the FileDiff admin UI.

Review Request #3817 — Created Jan. 30, 2013 and submitted Jan. 30, 2013, 11:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added nice styling of diffs in the FileDiff admin UI.

The FileDiff admin UI previously just showed diffs with no whitespace
preservation, which was useless. We now style it with Pygments, which is
nicer to look at.

Testing Done

Tested with some diffs. They looked nice.

Files

Issues

Description	From	Last Updated
This should be parent_diff.label and parent_diff.allow_tags, right?	david	Jan. 30, 2013, 10:38 p.m.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/diffviewer/admin.py
  Ignored Files:
    reviewboard/static/rb/css/admin.less

reviewboard/diffviewer/admin.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should be parent_diff.label and parent_diff.allow_tags, right?
```

Change Summary:

Fixed the function the label and allow_tags were set on.

Branch:

-	release-1.7.x
+	master

Diff:

Revision 2 (+50)

Show changes

	reviewboard/diffviewer/admin.py
	reviewboard/static/rb/css/admin.less
	reviewboard/templates/admin/diffviewer/filediff/change_form.html

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/diffviewer/admin.py
  Ignored Files:
    reviewboard/static/rb/css/admin.less
    reviewboard/templates/admin/diffviewer/filediff/change_form.html

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (4a60ef891d44cb639f70fd9b69e78d2f4cd43b63)