Summary

Fix the console fallbacks to not break older browsers.

Review Request #3814 — Created Jan. 29, 2013 and submitted Jan. 30, 2013, 11:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix the console fallbacks to not break older browsers.

The console fallbacks were designed to work if no console API was
defined, but it still ended up accessing stuff inside of console. It
also had some unused code at the end. This has been fixed and should
restore compatibility with Firefox 3.x and IE.

Testing Done

Tested with a valid console API, and made sure it still worked.

Simulated console being undefined, and ensured that now works as well.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
  Ignored Files:
    reviewboard/static/rb/js/utils/consoleUtils.js

What do you mean by "simulated console being undefined"?

chipx86 Jan. 29, 2013, 11:28 p.m.

window.console. It's just an object, so I overwrote it with:

    window.console = undefined;

Which is what you'd get if you didn't have those APIs in the first place.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (62e63833c58b5ac8068199bb34897569654448e2)