Add pyflakes support to reviewbot

Review Request #3806 — Created Feb. 4, 2013 and submitted

Information

ReviewBot

Reviewers

Add support for pyflakes, a Python code quality tool.
Running in our local Review Board.
Description From Last Updated

Let's change this to "class PyflakesTool(Tool):" I know the pep8 tool isn't following the proper style, I plan on fixing …

SM smacleod

Let's change this to "Pyflakes"

SM smacleod

I don't think this description is accurate "Unlike PyLint, Pyflakes checks only for logical errors in programs; it does not …

SM smacleod
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        bot/setup.py
        bot/reviewbot/tools/pyflakes.py
      Ignored Files:
    
    
  2. 
      
SM
  1. Just a couple small things and this should be good to go.
  2. bot/reviewbot/tools/pyflakes.py (Diff revision 1)
     
     
    Show all issues
    Let's change this to "class PyflakesTool(Tool):"
    
    I know the pep8 tool isn't following the proper style, I plan on fixing that.
  3. bot/reviewbot/tools/pyflakes.py (Diff revision 1)
     
     
    Show all issues
    Let's change this to "Pyflakes"
  4. bot/reviewbot/tools/pyflakes.py (Diff revision 1)
     
     
    Show all issues
    I don't think this description is accurate "Unlike PyLint, Pyflakes checks only for logical errors in programs; it does not perform any check on style" - https://launchpad.net/pyflakes
    
    Let's go with something like "Checks code for Python errors."
    
    
  5. 
      
MR
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        bot/setup.py
        bot/reviewbot/tools/pyflakes.py
      Ignored Files:
    
    
  2. 
      
SM
  1. Ship It!
  2. 
      
MR
Review request changed
Status:
Completed
Change Summary:
Pushed to master (be44ba37f2a2ce5c8ba5c683710348a76151ba1d). Thanks!