Add pyflakes support to reviewbot
Review Request #3806 — Created Feb. 4, 2013 and submitted
Add support for pyflakes, a Python code quality tool.
Running in our local Review Board.
| Description | From | Last Updated |
|---|---|---|
|
Let's change this to "class PyflakesTool(Tool):" I know the pep8 tool isn't following the proper style, I plan on fixing … |
SM smacleod | |
|
Let's change this to "Pyflakes" |
SM smacleod | |
|
I don't think this description is accurate "Unlike PyLint, Pyflakes checks only for logical errors in programs; it does not … |
SM smacleod |
SM
-
Just a couple small things and this should be good to go.
-
bot/reviewbot/tools/pyflakes.py (Diff revision 1) Let's change this to "class PyflakesTool(Tool):" I know the pep8 tool isn't following the proper style, I plan on fixing that.
-
-
bot/reviewbot/tools/pyflakes.py (Diff revision 1) I don't think this description is accurate "Unlike PyLint, Pyflakes checks only for logical errors in programs; it does not perform any check on style" - https://launchpad.net/pyflakes Let's go with something like "Checks code for Python errors."
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: bot/setup.py bot/reviewbot/tools/pyflakes.py Ignored Files: