Summary

Fix setting time_added when publishing a review request.

Review Request #3800 — Created Jan. 27, 2013 and submitted Jan. 27, 2013, 7:25 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-1.7.x

Bugs

1897

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix setting time_added when publishing a review request.

The change added to set time_added to the publish time caused the
creation time to always be the publish time for every publish, not just
the first.

We now only set this when there hasn't been any changes previously made
to the review request and it's being published the first time.

Testing Done

Tested updating review requests and publishing the changes. No creation time change.

Tested closing a review request (tried submit and discard) and reopening, making changes,
and publishing. No creation time change.

Tested publishing a very old draft review request that was never published, and saw the
creation time reflect the current time.

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/models.py
  Ignored Files:

Ship it!

```
Ship It!
```

Ship it!

reviewboard/reviews/models.py (Diff revision 1)

Sorry, I added this change earlier, should have thought about the subsequent publishes  to reviewrequest. I considered changes to reviews, but dint think about the review_request itself getting updated.

chipx86 Jan. 27, 2013, 7:13 p.m.
```
No prob. Thanks for the review!
```

Status:: Completed