Fix setting time_added when publishing a review request.
Review Request #3800 — Created Jan. 27, 2013 and submitted
| Information | |
|---|---|
| chipx86 | |
| Review Board | |
| release-1.7.x | |
| 1897 | |
| Reviewers | |
| reviewboard | |
Fix setting time_added when publishing a review request. The change added to set time_added to the publish time caused the creation time to always be the publish time for every publish, not just the first. We now only set this when there hasn't been any changes previously made to the review request and it's being published the first time.
Tested updating review requests and publishing the changes. No creation time change. Tested closing a review request (tried submit and discard) and reopening, making changes, and publishing. No creation time change. Tested publishing a very old draft review request that was never published, and saw the creation time reflect the current time.
RA
-
-
reviewboard/reviews/models.py (Diff revision 1) Sorry, I added this change earlier, should have thought about the subsequent publishes to reviewrequest. I considered changes to reviews, but dint think about the review_request itself getting updated.
This is a review from Review Bot. Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/models.py Ignored Files: