Fix "Review ID" column in the dashboard datagrid with a local site.

Review Request #3786 — Created Jan. 22, 2013 and submitted

david
Review Board
release-1.7.x
reviewboard
Fix "Review ID" column in the dashboard datagrid with a local site.

The review ID column would properly select which database field to access,
except DashboardDataGrid was popping the "local_site" value out of kwargs before
delegating to ReviewRequestDataGrid.
Created a local site and published a review request to it. Before this change, I
saw a review ID of "5" even though the URL was /s/test-site/r/1/. After this
change, saw a review ID of "1" in the dashboard.
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/datagrids.py
      Ignored Files:
    
    
  2. 
      
mike_conley
  1. Looks good to me - why were we even popping this in the first place?
    1. I think at least at one point, it was because a parent class would end up being passed this parameter and didn't know what to do with it.
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.7.x (85d67ba) and release-1.6.x (1f14cce).
Loading...